Links empty state claims "All links are disabled" when a filter matches nothing

[DennisAlund]

Found while reviewing #48. Pre-existing, not caused by that PR.

src/pages/links.tsx:221 picks the empty-state copy from links.length > 0, which does not account for which filter is active.

Reproduction

30 links, none expired. Click the Disabled filter chip.

• filtered.length === 0, so the empty state renders.
• links.length > 0, so it renders t("links.allDisabled"): All links are disabled. Toggle "Show disabled" to see them.
• Meanwhile toolbar-count reads 30 links.

The copy states the inverse of the truth, and it points at a "Show disabled" toggle that the filter chips replaced. links.showDisabled (src/i18n/en.ts:50) is now referenced nowhere outside the i18n files.

Fix

Branch the empty-state copy on filter. Add keys for the active/disabled/all cases to src/i18n/en.ts, id.ts, and sv.ts, and drop the orphaned links.showDisabled key.

[DennisAlund]

Fixed on main by 4e5c81f ("Give the links empty state a third case and honest copy"), which landed in #50. That PR did not reference this issue, so it stayed open.

The links.length > 0 branch at the old src/pages/links.tsx:221 is gone. The empty-state copy now comes from a three-case reason the service computes:

• LinksEmptyReason = "no-links" | "all-disabled" | "no-matches" (src/services/link-management.ts:70)
• The service picks between them on the empty path from an unfiltered catalog count (src/services/link-management.ts:125-137): empty catalog gives no-links; a non-empty catalog with status === "active" and no search gives all-disabled; anything else gives no-matches.
• The page renders off that reason (src/pages/links.tsx:277-281).

The orphaned links.showDisabled key is dropped from en.ts, id.ts and sv.ts, and links.allDisabled now points at the filter chip that replaced the toggle: All links are disabled. Pick the "Disabled" filter to see them.

The reproduction is a regression test on main, src/__tests__/page/links-page.test.ts:630, "does not claim every link is disabled when the disabled filter matched nothing". The toolbar-count divergence noted in the report is covered at links-page.test.ts:651.

Verified on main: yarn vitest run src/__tests__/page/links-page.test.ts src/__tests__/service/link-page-service.test.ts gives 56 passed.