[Testing] Add regression tests for network data race fixes - #8635
[Testing] Add regression tests for network data race fixes#8635janezpodhostnik wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f244679 to
c3cbf10
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Adds deterministic regression coverage for the network-layer race fixes from #8633. Each new test was verified to fail (assertion failure or
-racereport) with the corresponding fix reverted, and to pass with it.Changes
network/slashing: first tests for the package. Verify the violations consumer does not mutate the caller'sViolationand that one violation can be reported concurrently through all entry points.SpamRecordCache: same-record concurrentGet/AdjustWithInittest. The existing concurrency tests only exercised disjoint records and did not catch the race. Also verifies the returned penalty is the one produced by the caller's own adjustment.AppSpecificScoreCache: same-peer concurrent update/read test, for the same reason.Related: #8633
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.