[Testing] Fix flaky tests exposed by parallel test scheduling - #8640
[Testing] Fix flaky tests exposed by parallel test scheduling#8640janezpodhostnik wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
418444c to
3f9f284
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3f9f284 to
74d0d2d
Compare
74d0d2d to
0477834
Compare
0477834 to
61e85aa
Compare
Flaky test fixes for failures that surfaced once slow test packages were scheduled first (heavier contention at the start of a full-suite run), plus one pre-existing tail flake.
engine/access/state_stream/backend: widen per-block exec-data liveness waits (1s -> 10s); they timed out under full-suite load.network/alsp/managerRepeatOffender: poll for the first penalty change instead of sleeping exactly one heartbeat interval, which could observe 0 or 2 decays when the heartbeat ticker was delayed.ledger/complete/walcheckpoint test: redraw random payloads on duplicate encoded keys. Keys can be as short as 1 byte (~1/256 collision per pair, ~130 payloads per trie), which made the payload comparison nondeterministic.engine/verification/fetcher/chunkconsumer: assert the multiset instead of the exact receive order in both "receive N" subtests; the consumer's 3 concurrent workers append in nondeterministic order.All fixes preserve the original assertions' strength. Validation: per-test stress runs (3x-50x,
-racewhere relevant) and clean 10x full-suite campaigns.Related: #8639
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.