Skip to content

fix(cli): reject malformed install options before replacement - #119

Merged
vincentkoc merged 1 commit into
mainfrom
fix/validate-install-options
Nov 20, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/validate-install-options

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Summary

A force install with a bare --name silently selected the source repository's name. With two local repositories both named demo, the packaged CLI exited zero and replaced the existing plugin and its generated skill. The install command now validates all trailing arguments before it starts Git.

Compatibility

This applies to the shared install entry point for Codex, Claude Code, and Hermes. Omitting --name still uses the source name. Missing values, conflicting explicit names, unknown flags, and stray positional arguments fail before replacement. The existing clone deadline precedence and validation are preserved.

Verification ledger

  • A committed Codex fixture reproduces the wrong replacement on the previous code. The regression test checks the original revision after each malformed invocation and proves an explicitly named replacement succeeds.
  • A separate production-only npm installation ran the CLI against two local Git sources. The rejected calls preserved the installed skill, generated skill, registry and manifest byte-for-byte. The valid replacement updated both skill copies.
  • All 16 local suites and the offline production package check passed.

@clawsweeper

clawsweeper Bot commented Nov 20, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 20, 2026 15:55
@vincentkoc
vincentkoc merged commit 37b7e4b into main Nov 20, 2026
11 checks passed
@vincentkoc
vincentkoc deleted the fix/validate-install-options branch November 20, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant