Repository navigation
fix(mcp): cap concurrent babelfish_task_start processes - #22
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 30, 2026, 12:29 AM ET / 04:29 UTC (Revision 14). ClawSweeper reviewWhat this changesThe branch limits background tasks in Babelfish’s optional Hermes MCP server to eight occupied Python processes, keeps slots reserved until child exit, publishes results promptly, and adds tests, documentation, and stacked pagination and dependency updates. Merge readiness⛔ Blocked before merge - 7 items remain This PR addresses a task-cap behavior that is still absent from current main. The child-exit accounting appears to resolve the earlier lifecycle concern, but the unconditional eight-task default needs a maintainer compatibility decision, current-head behavior proof remains incomplete, and the branch conflicts with main. Priority: P2 Review scores
Verification
How this fits togetherBabelfish’s optional MCP server receives background tool and command requests from an MCP client and runs them in isolated Hermes Python processes. Clients then poll task status or stop a task, while the server tracks when each process releases capacity. flowchart LR
A[MCP client] --> B[Background task start]
B --> C{Eight slots occupied?}
C -->|No| D[Hermes Python process]
C -->|Yes| E[Capacity error]
D --> F[Task status]
D -->|Process exits| C
Decision needed
Why: The prior API admitted additional tasks, and source checks cannot decide the compatibility policy for existing MCP clients. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep result publication separate from process occupancy, preserve existing task-start behavior by default unless maintainers approve the new limit, and validate the chosen upgrade path with a current-head real-client trace. Do we have a high-confidence way to reproduce the issue? Yes, from source: current main has no task-start capacity guard, and the PR’s focused checks exercise a ninth start. I did not execute the checkout. Is this the best way to solve the issue? Unclear. Tracking actual child occupancy addresses the resource bound, but the unconditional default is not yet an approved upgrade-safe policy. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 3a079b6ba9dd. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (13 earlier review cycles; latest 8 shown)
|
|
@clawsweeper re-review
Slots now stay reserved until the isolated child exits. Live
The eight-task ceiling is unchanged. That default is still a maintainer product call. Please either accept it or say you want it opt-in. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Isolated helper occupancy still waits for process exit. Task status completes or fails when the helper returns, so task_stop cannot discard a result that already landed. Claw P2 on openclaw#22. Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>
|
@clawsweeper re-review
Windows 11 cannot catch |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
112723a to
e0b61bc
Compare
Limit background Hermes calls to eight occupied process slots while publishing completed results immediately. Co-authored-by: Sebastien Tardif <sebtardif@ncf.ca>
e0b61bc to
3c9b646
Compare
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(mcp): cap concurrent babelfish_task_start processes This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Cap
babelfish_task_startat eight occupied isolated Hermes processes. Task status becomes completed or failed when the helper returns, while its slot remains reserved until the child exits; stopping or timing out a task cannot admit a replacement during delayed termination.Completed @SebTardif's fix with the original contributor credit. Child launch failures release their slots; process errors after launch do not falsely count as exit. Updated the README, MCP guide, compatibility reference, and Unreleased changelog. No command names or trust permissions change.
Proof: the previous MCP server fails the ninth-start regression. The corrected version passed
npm run check(115 tests) andnpm run pack:checkon Linux Crabbox with npm 11.19.1. Tests include real Python children that delay termination after stop, completion, and timeout; status remains available while their slots stay occupied. Codex autoreview found no actionable P0–P2 findings. Cross-platform, CodeQL, and constrained-memory CI passed on the merged PR head: https://github.com/openclaw/babelfish/actions/runs/36669201543.The combined dependency, pagination, task, and hook candidates also passed all 134 tests, package validation, and a zero-advisory audit on Linux.