Repository navigation
fix(import): read folded and literal YAML descriptions - #44
Conversation
A one-line description match treated the block marker as the description and left the indented lines in generated frontmatter. Commands, agents, and output styles all use that match. Folded lines join with spaces. Literal lines keep their breaks. One-line descriptions stay the same. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 1, 2026, 5:54 AM ET / 09:54 UTC (Revision 2). ClawSweeper reviewWhat this changesThe PR adds a shared reader for folded and literal YAML descriptions and preserves surrounding metadata, copied skill content, and regeneration rollback. Merge readiness✅ Ready for maintainer review The repaired head resolves all three prior findings, and no actionable introduced defect remains. The fix is still needed because current main retains the faulty one-line description reader. Priority: P2 Review scores
Verification
How this fits togetherBabelfish imports plugin Markdown from Claude Code and Codex into OpenClaw skills. Its frontmatter reader supplies descriptions for generated skills and output styles while preserving other source metadata. flowchart LR
A[Plugin Markdown] --> B[Split frontmatter and body]
B --> C[Read description scalar]
C --> D[Fold or preserve line breaks]
D --> E[Generated skills and output styles]
B --> F[Copied skills and assets]
E --> G[OpenClaw]
F --> G
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep one bounded scalar reader shared by the import paths, with supported YAML semantics documented and existing metadata and transactional regeneration preserved. Do we have a high-confidence way to reproduce the issue? Yes, from source: current main reads a block marker as the description and leaves its continuation lines in generated frontmatter. This review did not execute the importer. Is this the best way to solve the issue? Yes. A shared scalar reader repairs both affected import paths without adding dependencies or changing public contracts, and the repaired fixtures cover the prior failures. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against cc96f880659d. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
@clawsweeper re-review Exact head The reviewed scalar repair now preserves comments, indentation, more-indented line breaks, repeated blanks, clip/strip/keep semantics, frontmatter closing boundaries, and existing next-line metadata. Focused121/full181/package checks and independent exact-head review passed. Real LF/CRLF regeneration and malformed-input rollback are covered; the updated body states the bounded compatibility contract. Please supersede the prior-head verdict and review this repaired head. |
|
🦞👀 Re-review progress:
|
Summary
Compatibility
keep-coding-instructionsvalues remain supported.Verification
Exact head:
ace8b59ed5f410287770a9716f21583aa1819c5d, against maincc96f880659d979db360d9065880b1af2512feb8.npm run check: build and 181 tests passed in 11 files.npm run pack:check: 24 files, 288417 unpacked bytes.The expected-value fixtures cover YAML 1.2.2 block-scalar cases: comments, indentation indicators in either order, more-indented content, repeated blanks, clip/strip/keep, empty blocks, missing final line breaks, and invalid headers. Real regeneration tests exercise commands, agents, output styles, copied skills/assets, both LF and CRLF, unchanged metadata/body handling, and rollback after a malformed description.
The independent review's next-line metadata finding was fixed and re-reviewed. Prior MCP/Stop/expansion repairs were integrated only to resolve actual main conflicts; the final introduced diff remains scoped to scalar import behavior.
Fresh ClawSweeper and exact-head CI, low-memory, and CodeQL remain required before merge.