Repository navigation
fix(web): clarify archived channels and integration secrets - #330
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesDisable archived-channel message and reply composers across chat and embeds, explain recovery, and re-enable them after restoration. Example: A user opens archived #general and tries to send “Can anyone see this?”.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this PR fixes a current mismatch between the web composers and the server’s archived-channel contract; no blocking defect was found. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherChannel metadata and realtime updates feed the web chat and embedded views, which derive composer availability before submitting messages to the existing API. flowchart TD
ChannelMetadata --> ChatApp
ChannelMetadata --> EmbeddedViews
RealtimeUpdates --> ChatApp
RealtimeUpdates --> EmbeddedViews
ChatApp --> SharedComposers
EmbeddedViews --> SharedComposers
SharedComposers --> PostingAPI
Technical reviewBest possible solution: Land the focused frontend alignment with the existing archive contract and retained realtime restoration behavior. Do we have a high-confidence way to reproduce the issue? Current-main source exposes enabled archived-channel composers despite server rejection, and the contributor supplies matching before/after browser evidence; no target code was run during this review. Is this the best way to solve the issue? The patch uses existing channel metadata, realtime refresh, and shared composer controls without changing API permissions, stored state, or archive semantics. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 38d16cff5204. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (4 earlier review cycles)
Reviewed November 19, 2026, 2:19 AM ET / 07:19 UTC (Revision 5). |
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
eb693fb to
fc621b8
Compare
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
Refresh compatible dependencies and make the file-mode preservation fixture independent of the process umask. Co-authored-by: Krasimir Kralev <263465593+KrasimirKralev@users.noreply.github.com>
What Problem This Solves
Archived channels offer composers even though the server rejects new posts and replies. Rotated integration secrets also appear in text fields with no accessible name.
User Impact
Channel and thread composers now explain that the channel is archived and how to continue, including embedded views. Restoring the channel re-enables them. Screen readers can identify the one-time signing-secret fields for slash commands and event subscriptions.
Why This Change Was Made
The web app now observes the server's existing archive rule, including realtime restore events. Each revealed secret is associated with its own row's label. This includes the verified fix from #333, with credit to @KrasimirKralev for both fixes.
The maintenance refresh updates eligible web, desktop, and development dependencies after the 48-hour cooldown. It preserves the Node and Go floors, security overrides, SQLite/libc pairing, Virtua scroll-restoration pin, and the protocol generator's TypeScript 5 compiler. No manual deployment is part of this PR.
Evidence
The three regression checks fail on unchanged main: main and embedded archived composers are still enabled, and the revealed secret has no accessible name. Independent P0–P2 review of each original fix is clean. The final combined checks pass: all 19 affected Playwright tests, web utilities and Go package tests, FakeCo and desktop tests, typechecks, lint/format, docs build, and Go vulnerability scan. The one Go fixture failure under a restrictive umask was fixed and the exact test passed on rerun. The embedded app builds repeatably and the tested source hashes match the reviewed files.
Contributor screenshots inspected: synthetic workspace and messages only.
The signing-secret change affects accessibility names without a visual change; the browser checks assert each name and its own row's value without publishing any secret values.