Skip to content

refactor: share SDK selection and mock runtime implementations - #148

Merged
vincentkoc merged 4 commits into
mainfrom
refactor/remaining-duplication
Nov 4, 2026
Merged

vincentkoc merged 4 commits into
mainfrom
refactor/remaining-duplication

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

SDK certificate/full-surface selection, missing inspection defaults, generated mock value runtimes, and CLI inspection-option parsing repeat the same implementation.

Why This Change Was Made

Share the repeated code through existing internal modules and private helpers. Preserve declaration resolution/normalization and snapshot-only lookup, the certificate module's existing export, fresh inspection defaults, generated-module isolation, and CLI validation order/defaults. No new package exports or dependencies. Removes 70 net lines including declaration-selection regression coverage.

User Impact

No intended behavior change.

Evidence

  • 138 initial targeted inspector/report/mock/packed test executions pass.
  • All 92 CLI/helper-CLI tests pass.
  • All 26 packed SDK tests pass with the new conditional-export/precedence/snapshot/normalization regression.
  • Sampled generic/root generated mock runtime sources are byte-identical to the original.
  • Package contents validation passes.
  • Crabpot source smoke ran across 60 fixtures and reported the existing 83 corpus breakages.
  • Independent reviewers found no contract changes.

@clawsweeper

clawsweeper Bot commented Nov 4, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 4, 2026 18:13
@vincentkoc
vincentkoc requested a review from a team as a code owner November 4, 2026 18:13
@vincentkoc
vincentkoc merged commit f5697a5 into main Nov 4, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the refactor/remaining-duplication branch November 4, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant