Repository navigation
refactor: share SDK selection and mock runtime implementations - #148
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
SDK certificate/full-surface selection, missing inspection defaults, generated mock value runtimes, and CLI inspection-option parsing repeat the same implementation.
Why This Change Was Made
Share the repeated code through existing internal modules and private helpers. Preserve declaration resolution/normalization and snapshot-only lookup, the certificate module's existing export, fresh inspection defaults, generated-module isolation, and CLI validation order/defaults. No new package exports or dependencies. Removes 70 net lines including declaration-selection regression coverage.
User Impact
No intended behavior change.
Evidence