Skip to content

refactor: reuse fixture inspection and schema sampling blocks - #149

Merged
vincentkoc merged 3 commits into
mainfrom
refactor/shared-source-blocks
Nov 4, 2026
Merged

vincentkoc merged 3 commits into
mainfrom
refactor/shared-source-blocks

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

API inspection preparation, schema sample assignment, and seam-inventory log construction repeat the same code.

Why This Change Was Made

Share private API loaders while retaining the distinct six- and eight-field inspection whitelists, report fallback rules, and root resolution. Reuse the existing seam-inventory finding helper and one local schema assignment helper, preserving required empty-string keys and boolean/fallback ordering. No public exports or dependencies change. Removes 24 net lines.

User Impact

No intended behavior change.

Evidence

  • All 77 targeted API/report/capture/workspace/readiness tests pass.
  • All four affected API façades and supplied-report paths match original outputs in differential checks.
  • Schema outputs match the original across 36 cases, including required empty-string keys, booleans, nested configuration, and minimum properties.
  • Package contents validation passes.
  • Crabpot source smoke ran across 60 fixtures and reported the existing 83 corpus breakages.
  • Independent review found no contract changes.

@clawsweeper

clawsweeper Bot commented Nov 4, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 4, 2026 19:25
@vincentkoc
vincentkoc requested a review from a team as a code owner November 4, 2026 19:25
@vincentkoc
vincentkoc merged commit c7a09a0 into main Nov 4, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the refactor/shared-source-blocks branch November 4, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant