Skip to content

[cifmw_cephadm] add generic ceph-config override passthrough - #4112

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
tosky:ceph-generic-config-override
Aug 25, 2026
Merged

[cifmw_cephadm] add generic ceph-config override passthrough#4112
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
tosky:ceph-generic-config-override

Conversation

@tosky

@tosky tosky commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The role applies a fixed set of ceph config set commands in tasks/cephadm_config_set.yml, one task per option. A scenario that needs to tune any other cluster option currently has to patch the role. Add a generic, opt-in cifmw_cephadm_extra_config list so scenarios can apply arbitrary ceph config set <who> <key> <value> entries without a new task per option. It defaults to empty (no-op) and is applied after the built-in configuration, so it can also override earlier values.

For example, a deployment can bound the MDS cap-revoke stall that wedges a single-worker CephFS/NFS-Ganesha consumer by evicting an unresponsive cap-holder before it hits session_autoclose:

cifmw_cephadm_extra_config:
  - who: mds
    key: mds_cap_revoke_eviction_timeout
    value: "25"

Assisted-By: Claude Opus 4.8 noreply@anthropic.com
Signed-off-by: Luigi Toscano ltoscano@redhat.com

@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fultonj

fultonj commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

+1 to this generic solution. Thanks @tosky

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/415e017909054217a5f4c32e06526fda

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 05m 27s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 32m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 53m 56s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 18m 02s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 54m 05s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 58s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 6h 49m 06s
cifmw-crc-podified-edpm-baremetal-bootc RETRY_LIMIT in 3h 00m 53s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 56s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 43s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 5m 56s

@tosky
tosky marked this pull request as ready for review August 17, 2026 22:33
The role applies a fixed set of `ceph config set` commands in
tasks/cephadm_config_set.yml, one task per option. A scenario that needs
to tune any other cluster option currently has to patch the role. Add a
generic, opt-in `cifmw_cephadm_extra_config` list so scenarios can apply
arbitrary `ceph config set <who> <key> <value>` entries without a new
task per option. It defaults to empty (no-op) and is applied after the
built-in configuration, so it can also override earlier values.

For example, a deployment can bound the MDS cap-revoke stall that wedges
a single-worker CephFS/NFS-Ganesha consumer by evicting an unresponsive
cap-holder before it hits session_autoclose:

    cifmw_cephadm_extra_config:
      - who: mds
        key: mds_cap_revoke_eviction_timeout
        value: "25"

Assisted-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Luigi Toscano <ltoscano@redhat.com>
@tosky
tosky force-pushed the ceph-generic-config-override branch from 5f18e3a to 67df98c Compare August 17, 2026 22:34
@tosky

tosky commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Internally tested, ready for review.

@tosky tosky changed the title cifmw_cephadm: add generic ceph-config override passthrough [cifmw_cephadm] add generic ceph-config override passthrough Aug 17, 2026

@fultonj fultonj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sdatko sdatko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@sdatko sdatko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sdatko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit f0c58cd into openstack-k8s-operators:main Aug 25, 2026
17 checks passed
@tosky
tosky deleted the ceph-generic-config-override branch August 25, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants