From bbd8e0220ce5bb1d8f831374808457bc86b2ade9 Mon Sep 17 00:00:00 2001 From: Johnathan Leung Date: Tue, 8 Sep 2026 19:27:12 +0000 Subject: [PATCH] Review follow-ups: document the clippy rewrite, fix a stale workflow comment The v0.1.1-fh3.1-1 changelog entry claimed identical sources to StreamingFast's tag while this branch also rewrites read_all_system_contracts for clippy; list that under Fixed and limit the identity claim to Cargo.toml/Cargo.lock. The sf-release.yml secrets comment described a private reth fork nothing pins. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01YHvxpuVpZfzefJgwgqjAzn --- .github/workflows/sf-release.yml | 5 +++-- CHANGELOG.md | 15 ++++++++++----- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/.github/workflows/sf-release.yml b/.github/workflows/sf-release.yml index bb1a42b7..f13d504e 100644 --- a/.github/workflows/sf-release.yml +++ b/.github/workflows/sf-release.yml @@ -118,8 +118,9 @@ jobs: # buildx, so branch/PR (release) and tag (maxperf) caches stay separate. cache-from: type=gha cache-to: type=gha,mode=max - # Read access to the private pinax-network/reth fork for cargo's git - # fetch inside the build (mounted, never baked into a layer). + # Optional read token for git dependencies pinned to the private + # pinax-network org (see header and Dockerfile.sf); unused when none + # are. Mounted as a BuildKit secret, never baked into a layer. secrets: | github_token=${{ secrets.PAT_INTERNAL_REPOSITORIES }} build-args: | diff --git a/CHANGELOG.md b/CHANGELOG.md index 9d27899a..bed2cec5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,11 +11,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## v0.1.1-fh3.1-1 -First release built from the Pinax fork (`Johnaverse/reth-bsc` for testing, then -`pinax-network/reth-bsc`). Sources are identical to StreamingFast's `v0.1.1-fh3.1` -(`56c35604c`): same `Cargo.toml`, same `Cargo.lock`, so `--locked` resolves exactly the bytes -StreamingFast shipped. Dependencies still come from `streamingfast/reth` (tag -`bnb-v0.1.1-fh3.1`) and `streamingfast/evm` (`sf/v0.34.0`). +First release built from `pinax-network/reth-bsc`. `Cargo.toml` and `Cargo.lock` are identical +to StreamingFast's `v0.1.1-fh3.1` (`56c35604c`), so `--locked` resolves exactly the dependency +bytes StreamingFast shipped: `streamingfast/reth` tag `bnb-v0.1.1-fh3.1` and `streamingfast/evm` +`sf/v0.34.0`. One source file differs (see Fixed). + +### Fixed + +- `read_all_system_contracts` initialises `dir` at its declaration (clippy 1.98 + `needless_late_init`, which `ci.yml` runs with `-D warnings` on unpinned stable). Same behaviour; + the identical failure shows on `streamingfast/reth-bsc` `release/0.1.x`. ### Changed