Repository navigation
ci: add workflow to verify yarn create-workspace - #5468
Open
christoph-jerolimov wants to merge 4 commits into
Open
christoph-jerolimov wants to merge 4 commits into
christoph-jerolimov wants to merge 4 commits into
Conversation
PR Summary by QodoAdd CI coverage for yarn create-workspace
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by QodoView medium (2)
1. Scaffold check no longer verifies the generated lockfile
|
|
Important The |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5468 +/- ##
=======================================
Coverage 65.54% 65.54%
=======================================
Files 2775 2775
Lines 111253 111253
Branches 31292 31292
=======================================
Hits 72922 72922
Misses 37772 37772
Partials 559 559
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Follow-up to #4882 to keep the root create-workspace path covered in CI when package.json, yarn.lock, repo-tools, or this workflow change. Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Piped stdin trips inquirer with ERR_USE_AFTER_CLOSE in CI. Accept --name/--owner so the workflow can scaffold without a TTY, and install the seeded workspace lockfile without --immutable. Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
christoph-jerolimov
force-pushed
the
ci/create-workspace-workflow
branch
from
November 5, 2026 22:04
6d5ecca to
b116bff
Compare
Changed Packages
|
Yarn enables immutable installs under CI=true, which rejects the template seed lockfile. Pass --no-immutable for that step only. Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn create-workspace#4882: add a CI workflow that exercisesyarn create-workspacefrom the repo rootpackage.json,yarn.lock,workspaces/repo-tools/**, or the workflow itself--immutable, scaffolds a throwaway workspace, checks expected files, then installs and builds itTest plan
ci-create-workspace-test, finds scaffold files, and completesyarn build:allMade with Cursor