Animate#12
Open
wasnotrice wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a re-implementation of Shoes::Animate that accepts a Hash argument. The old syntax is still valid (this is similar to other methods like
#ovalthat have multiple signatures). Use in the old way like:or with a hash:
At this point, no other options are implemented, so only
:frameratemakes any difference.The merge commit here is really messy. Something bad happened in previous merges. The merge replaces the Rakefile (important!), the Gemfile, and some miscellaneous style work that I think was pulled into shoes/master???