Repository navigation
Conversation
…he setting The desktop app turns HTML-in-Canvas on unless the classic canvas was chosen, and the page defaults to the GPU canvas there. A canvas that cannot start, or whose GPU resets twice, gives way to the classic canvas for the session; a single reset rebuilds it once WebGL is back. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
… the classic canvas The connection shader named a variable 'active', a reserved word in GLSL ES 3.00, so it never compiled and no connection was drawn since phase 3. A shader that fails to compile now logs its driver log and gives way to the classic canvas, rather than leaving parts of the graph undrawn. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
The live layer hands React Flow new node objects on every render, without the size React Flow measured, so React Flow hid each live node until it measured it again. Hiding the node blurred the field being typed in, so a Prompt took one character at most. Renders now carry the measured size. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
It finds the canvas, its empty area and its nodes on the GPU canvas as well as the classic one, makes the new Prompt live before typing in it, and checks the text reached the store. NODE_BANANA_GPU_CANVAS=0 runs it on the classic canvas; NODE_BANANA_SMOKE_CHROMIUM_FLAGS passes Chromium switches (a container needs --no-sandbox), and Linux's key-storage prompt is answered with session-only keys. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
The acceptance and large-workflow runs check recovery through the classic canvas's text fields and nodes, and the canvas performance runner measures the classic canvas, so they launch with NODE_BANANA_GPU_CANVAS=0 unless told otherwise. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Willie · project thread
Before: the GPU canvas was a preview you had to turn on in Settings › Canvas and restart for, and the desktop app drew with React Flow.
After: the desktop app draws with the GPU canvas from first launch. Settings › Canvas › "GPU canvas" turns it off, which goes back to the classic React Flow canvas straight away, for this one release. The browser build keeps the classic canvas.
Stacked on #189 (phase 4). Retarget to
feature/gpu-canvasonce #187–#189 merge.How
electron/lib/gpu-canvas.cjsturns onCanvasDrawElementat every launch unless the classic canvas was chosen.NODE_BANANA_GPU_CANVAS=1/0overrides a single run. On the page,node-banana-gpu-canvasnow defaults to on when the desktop bridge is present and off otherwise.webglcontextlost), the GPU canvas is rebuilt once WebGL comes back. A second reset falls back to classic. I checked this in Electron by forcing context loss withWEBGL_lose_context.active, which is a reserved word in GLSL ES 3.00, so no connections were drawn. Separately, live nodes lost their React Flowmeasuredsize on every render. React Flow then hid the node, which blurred the field being typed in, so a Prompt only ever got one character. Both were ported to GPU canvas phase 3: editing on the canvas #188/GPU canvas phase 4: live content #189, and I merged those versions here.electron:smokenow works on either canvas: it adds a Prompt, makes it live, types into it and checks the store. Acceptance, large-workflow andelectron:performancecheck or measure through classic-canvas DOM, so they pinNODE_BANANA_GPU_CANVAS=0unless you override it.Checks
npm run typecheck: clean.npm run lint: 0 errors.npx vitest run: 382 files passed, 6560 tests. This includes the newsetting.test.ts, and the projectsFolder test passed this time.npm run electron:test: 56 passed.electron:smoke --productionunder xvfb + SwiftShader: passes on the GPU canvas and withNODE_BANANA_GPU_CANVAS=0.🤖 Generated with Claude Code
https://claude.ai/code/session_013ZXTt1yZN46oNN4z4tU5vo
Generated by Claude Code