The Docs Link Check workflow currently validates generated docs in pull requests against https://spike.ist instead of the checked-out PR artifact.
In #287, lychee reported 1307 errors, mostly repeated 404s for pages such as:
Those pages existed in the PR's generated docs/ tree, but they were not published on the live site yet. Because the workflow runs before deployment, checking https://spike.ist produces false positives for newly added or changed docs pages.
Root cause:
.github/workflows/docs-link-check.yaml runs lychee with --base-url https://spike.ist.
.lychee.toml remaps root/file URLs back to https://spike.ist/.
- Lychee's
--base-url resolves relative links; it does not make already-absolute https://spike.ist/... links resolve to local files.
(cached) entries in the report came from lychee cache reuse, but cache only amplified the visible failure; it did not cause the wrong target selection.
Expected behavior:
For PRs, lychee should validate internal site links against the checked-out/generated docs/ tree, not the currently deployed production site.
cc @v0lkan
The Docs Link Check workflow currently validates generated docs in pull requests against
https://spike.istinstead of the checked-out PR artifact.In #287, lychee reported 1307 errors, mostly repeated 404s for pages such as:
Those pages existed in the PR's generated
docs/tree, but they were not published on the live site yet. Because the workflow runs before deployment, checkinghttps://spike.istproduces false positives for newly added or changed docs pages.Root cause:
.github/workflows/docs-link-check.yamlruns lychee with--base-url https://spike.ist..lychee.tomlremaps root/file URLs back tohttps://spike.ist/.--base-urlresolves relative links; it does not make already-absolutehttps://spike.ist/...links resolve to local files.(cached)entries in the report came from lychee cache reuse, but cache only amplified the visible failure; it did not cause the wrong target selection.Expected behavior:
For PRs, lychee should validate internal site links against the checked-out/generated
docs/tree, not the currently deployed production site.cc @v0lkan