Skip to content

Commit dc01984

Browse files
committed
fix: make trigger recompute computed signals
1 parent 113f581 commit dc01984

2 files changed

Lines changed: 52 additions & 1 deletion

File tree

‎src/index.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,12 @@ export function trigger(fn: () => void) {
227227
const dep = link.dep;
228228
link = unlink(link, sub);
229229
const subs = dep.subs;
230-
if (subs !== undefined) {
230+
if ("getter" in dep) {
231+
dep.flags |= ReactiveFlags.Dirty;
232+
if (subs !== undefined) {
233+
propagate(subs, !!runDepth);
234+
}
235+
} else if (subs !== undefined) {
231236
propagate(subs, !!runDepth);
232237
shallowPropagate(subs);
233238
}

‎tests/trigger.spec.ts‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,3 +91,49 @@ test('should rerun effect once when writing a signal after reading it', () => {
9191
expect(triggers).toBe(2);
9292
expect(src1()).toBe(2);
9393
});
94+
95+
test('should trigger updates for computed signals', () => {
96+
let value = 1;
97+
const src1 = computed(() => value * 2);
98+
99+
expect(src1()).toBe(2);
100+
value = 2;
101+
trigger(src1);
102+
expect(src1()).toBe(4);
103+
});
104+
105+
test('should not rerun effects if upon trigger a computed returns the same value', () => {
106+
const src1 = computed(() => 42);
107+
108+
let triggers = 0;
109+
effect(() => {
110+
triggers++;
111+
src1();
112+
});
113+
114+
expect(triggers).toBe(1);
115+
116+
trigger(src1);
117+
expect(triggers).toBe(1);
118+
expect(src1()).toBe(42);
119+
});
120+
121+
test('should propagate updates through chained computed signals upon trigger', () => {
122+
let value = 1;
123+
const src1 = computed(() => value * 2);
124+
const src2 = computed(() => src1() * 10);
125+
126+
let triggers = 0;
127+
effect(() => {
128+
triggers++;
129+
src2();
130+
});
131+
132+
expect(triggers).toBe(1);
133+
expect(src2()).toBe(20);
134+
135+
value = 2;
136+
trigger(src1);
137+
expect(triggers).toBe(2);
138+
expect(src2()).toBe(40);
139+
});

0 commit comments

Comments
 (0)