From 16618fc067279e3530c5b0bac727edeffd66bca9 Mon Sep 17 00:00:00 2001 From: Oskar Niburski Date: Wed, 5 Dec 2018 13:10:22 -0800 Subject: [PATCH 1/2] update(message): Install convert command --- lib/arc/exceptions.ex | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/lib/arc/exceptions.ex b/lib/arc/exceptions.ex index 94fc845..f4a734a 100644 --- a/lib/arc/exceptions.ex +++ b/lib/arc/exceptions.ex @@ -4,10 +4,19 @@ defmodule Arc.MissingExecutableError do def exception(opts) do message = Keyword.fetch!(opts, :message) - msg = """ - Cannot locate executable: #{message} - """ + msg = case unix_operating_system?() do + true -> + "Please look into installing imagemagick first." + false -> + "" + end + + msg = msg <> " \n Cannot locate executable: #{message}" %__MODULE__{message: msg} end + + defp unix_operating_system?() do + {:unix, :darwin} == :os.type() + end end From 92d25bfb2b5078f31d0216f741b00ba54b8a3c96 Mon Sep 17 00:00:00 2001 From: Oskar Niburski Date: Wed, 5 Dec 2018 13:11:02 -0800 Subject: [PATCH 2/2] remove(asset): Remove asset host --- lib/arc/storage/s3.ex | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/arc/storage/s3.ex b/lib/arc/storage/s3.ex index cd15eba..b7a7492 100644 --- a/lib/arc/storage/s3.ex +++ b/lib/arc/storage/s3.ex @@ -6,7 +6,6 @@ defmodule Arc.Storage.S3 do destination_dir = definition.storage_dir(version, {file, scope}) s3_bucket = s3_bucket(definition) s3_key = Path.join(destination_dir, file.file_name) - asset_host = asset_host(definition) acl = definition.acl(version, {file, scope}) s3_options =