From b9db3a06fc36c398a455c07409e47ccec55dbdcd Mon Sep 17 00:00:00 2001
From: Rex Lorenzo <rexlorenzo@gmail.com>
Date: Tue, 16 Jun 2026 09:00:58 -0700
Subject: [PATCH] chore(codeql): simplify redundant null-conditionals in
 StudentList

Inside the `if (std.Student != null)` guard, ClassLevel/TermCode/Active
still used `std.Student?.` / `std?.Student?.`, which CodeQL flagged as
always-true conditions (cs/constant-condition). Drop the redundant
operators; keep the genuinely-nullable StudentInfo?. Behavior unchanged.
---
 web/Areas/Students/Services/StudentList.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/web/Areas/Students/Services/StudentList.cs b/web/Areas/Students/Services/StudentList.cs
index 22f724061..e320fef73 100644
--- a/web/Areas/Students/Services/StudentList.cs
+++ b/web/Areas/Students/Services/StudentList.cs
@@ -223,10 +223,10 @@ private static List<Student> CreateStudentListFromStudentGradYears(List<StudentC
                         LastName = std.Student.LastName,
                         MiddleName = std.Student.MiddleName,
                         FullName = std.Student.FullName,
-                        ClassLevel = std.Student?.StudentInfo?.ClassLevel,
-                        TermCode = std.Student?.StudentInfo?.TermCode,
+                        ClassLevel = std.Student.StudentInfo?.ClassLevel,
+                        TermCode = std.Student.StudentInfo?.TermCode,
                         ClassYear = std.ClassYear,
-                        Active = std?.Student?.Current == 1 || std?.Student?.Future == 1
+                        Active = std.Student.Current == 1 || std.Student.Future == 1
                     };
 
                     var classYears = activeYearOnly