Align JSON-LD output with DCAT#221
Open
LariDG wants to merge 9 commits into
Open
Conversation
Collaborator
Author
|
@agbeltran I have made a start here on what we discussed. Please let me know if this is what you had in mind and if there are any changes you would like. |
Contributor
Contributor
|
A few comments on remaining points: i) dcat:servesDataset should point to a dataset, so adding the service endpoints might be ok if they return datasets, ii) for the service URI, we should consider where the service is deployed (I only left localhost), iii) I tested the output in the json-ld playground, but we should test further and make sure everything is correct. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to issue: #172 and discussions with Alejandra.
The JSON endpoints previously declared DCAT terms in the
@contextinconsistently, every response was a flat dcat:Dataset regardless of whether it was a catalogue listing, a dataset, or a glossary entry. This PR reshapes the responses to be more inline with DCAT usage.Example of new structure after snippet put into json-ld playground:
http://localhost:8081/json/shots:Single shot endpoint (
http://localhost:8081/json/shots/11695):Due to cpf summary not being a dataset, changed the context to more appropriate definition: