You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR now conflicts with main because the code it patches no longer exists in that form. Commit 8b758f9 ("fix: rewrite firmware refvals extraction for new veritas format", 2026-07-25 — landed on main via #105) replaced the entire yq | jq extraction pipeline with a Python3+yaml extractor that handles both the old reference-values.json array format and the new veritas 0.5.1+/Trustee 1.2 reference_value base64-encoded-dict format, with explicit error handling instead of a bare crash on null.
That fix is broader than this PR's proposed one-line swap (which only handles the new format and would still crash on the old one), so I'd suggest closing this PR as superseded rather than rebasing it — current main's scripts/collect-firmware-refvals.sh already resolves the underlying bug reported in #102.
Thank you for the fix and for reporting it — apologies this PR sat long enough to be overtaken by a parallel rewrite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Resolves "collect-firmware-refvals" failing with:
Related Issue:
Closes #102