update with new agent standards

Author: dminnear-rh

src/cmd/cmd_suite_test.go

@@ -124,9 +124,7 @@ func verifyClusterGroupValues(valuesFile string, expectedClusterGroupValues *typ
 }
 
 func createTestDir() string {
-	dir, err := os.MkdirTemp("", "patternizer-test")
-	Expect(err).NotTo(HaveOccurred())
-	return dir
+	return GinkgoT().TempDir()
 }
 
 func runCLI(dir string, args ...string) *gexec.Session {

src/cmd/init.go

@@ -13,25 +13,21 @@ import (
 
 // runInit handles the initialization logic for the init command.
 func runInit(withSecrets bool) error {
-	// Get pattern name and repository root
 	patternName, repoRoot, err := pattern.GetPatternNameAndRepoRoot()
 	if err != nil {
 		return fmt.Errorf("error getting pattern information: %w", err)
 	}
 
-	// Find Helm charts in the repository
 	chartPaths, err := helm.FindTopLevelCharts(repoRoot)
 	if err != nil {
 		return fmt.Errorf("error finding Helm charts: %w", err)
 	}
 
-	// Process values-global.yaml
 	actualPatternName, clusterGroupName, err := pattern.ProcessGlobalValues(patternName, repoRoot, withSecrets)
 	if err != nil {
 		return fmt.Errorf("error processing global values: %w", err)
 	}
 
-	// Process cluster group values using the actual pattern name and cluster group name from the global values
 	if err := pattern.ProcessClusterGroupValues(actualPatternName, clusterGroupName, repoRoot, chartPaths, withSecrets); err != nil {
 		return fmt.Errorf("error processing cluster group values: %w", err)
 	}

src/cmd/init_test.go

@@ -61,10 +61,6 @@ var _ = Describe("patternizer init", func() {
 			_ = runCLI(tempDir, "init")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -118,10 +114,6 @@ var _ = Describe("patternizer init", func() {
 			_ = runCLI(tempDir, "init")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -182,10 +174,6 @@ var _ = Describe("patternizer init", func() {
 			_ = runCLI(tempDir, "init")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -235,10 +223,6 @@ var _ = Describe("patternizer init", func() {
 			_ = runCLI(tempDir, "init")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -297,10 +281,6 @@ var _ = Describe("patternizer init", func() {
 			_ = runCLI(tempDir, "init")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should respect the explicit singleArgoCD override", func() {
 			globalValuesFile := filepath.Join(tempDir, "values-global.yaml")
 			expectedGlobalValues := types.ValuesGlobal{
@@ -333,10 +313,6 @@ var _ = Describe("patternizer init --with-secrets", func() {
 			_ = runCLI(tempDir, "init", "--with-secrets")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -419,10 +395,6 @@ var _ = Describe("patternizer init --with-secrets", func() {
 			_ = runCLI(tempDir, "init", "--with-secrets")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -515,10 +487,6 @@ var _ = Describe("patternizer init --with-secrets", func() {
 			_ = runCLI(tempDir, "init", "--with-secrets")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -602,10 +570,6 @@ var _ = Describe("patternizer init --with-secrets", func() {
 			_ = runCLI(tempDir, "init", "--with-secrets")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the secrets template file", func() {
 			verifySecretTemplateCopied(tempDir)
 		})
@@ -695,10 +659,6 @@ var _ = Describe("patternizer init --with-secrets", func() {
 			_ = runCLI(tempDir, "init", "--with-secrets")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common pattern scaffold files", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})
@@ -789,10 +749,6 @@ var _ = Describe("patternizer init --with-secrets", func() {
 			_ = runCLI(tempDir, "init", "--with-secrets")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should not modify the secrets template file", func() {
 			actual, err := os.ReadFile(filepath.Join(tempDir, "values-secret.yaml.template"))
 			Expect(err).NotTo(HaveOccurred())

src/cmd/root.go

@@ -29,7 +29,6 @@ for a validated pattern, including values-global.yaml and values-<clustergroup>.
 When --with-secrets is specified, it also copies the secrets template and
 configures the pattern.sh script for secrets usage.`,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			// Check if "help" is passed as an argument
 			if len(args) > 0 && args[0] == "help" {
 				return cmd.Help()
 			}

src/cmd/upgrade.go

@@ -12,22 +12,18 @@ import (
 
 // runUpgrade handles the upgrade logic for the upgrade command.
 func runUpgrade(replaceMakefile bool) error {
-	// Determine repository root
 	_, repoRoot, err := pattern.GetPatternNameAndRepoRoot()
 	if err != nil {
 		return fmt.Errorf("error getting pattern information: %w", err)
 	}
 
-	// Paths
 	commonDirPath := filepath.Join(repoRoot, "common")
 	patternShPath := filepath.Join(repoRoot, "pattern.sh")
 
-	// Remove common/ directory if it exists
 	if err := fileutils.RemovePathIfExists(commonDirPath); err != nil {
 		return fmt.Errorf("error removing common directory: %w", err)
 	}
 
-	// Remove ./pattern.sh if it exists (symlink or file)
 	if err := fileutils.RemovePathIfExists(patternShPath); err != nil {
 		return fmt.Errorf("error removing pattern.sh: %w", err)
 	}

src/cmd/upgrade_test.go

@@ -51,10 +51,6 @@ var _ = Describe("patternizer upgrade", func() {
 			_ = runCLI(tempDir, "upgrade")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should copy the common scaffold files (except Makefile)", func() {
 			verifyPattenShCopied(tempDir)
 			verifyMakefileCommonCopied(tempDir)
@@ -92,10 +88,6 @@ var _ = Describe("patternizer upgrade", func() {
 			_ = runCLI(tempDir, "upgrade")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should not update Makefiles that already include Makefile-common", func() {
 			f, err := os.ReadFile(filepath.Join(tempDir, "Makefile"))
 			Expect(err).NotTo(HaveOccurred())
@@ -115,10 +107,6 @@ var _ = Describe("patternizer upgrade --replace-makefile", func() {
 			_ = runCLI(tempDir, "upgrade", "--replace-makefile")
 		})
 
-		AfterAll(func() {
-			os.RemoveAll(tempDir)
-		})
-
 		It("should update the common scaffold files (including Makefile)", func() {
 			verifyScaffoldFilesCopied(tempDir)
 		})

src/internal/embedded/embedded.go

@@ -2,8 +2,12 @@ package embedded
 
 import "embed"
 
+// Resources holds the embedded resources directory tree (pattern.sh, Makefile, etc.).
+//
 //go:embed resources/*
 var Resources embed.FS
 
+// Skills holds the embedded skills directory tree for IDE integrations.
+//
 //go:embed all:skills
 var Skills embed.FS

src/internal/fileutils/fileutils.go

@@ -16,7 +16,7 @@ import (
 func CopyFile(src, dst string) error {
 	sourceFileStat, err := os.Stat(src)
 	if err != nil {
-		return err
+		return fmt.Errorf("stat source file %s: %w", src, err)
 	}
 
 	if !sourceFileStat.Mode().IsRegular() {
@@ -25,25 +25,24 @@ func CopyFile(src, dst string) error {
 
 	sourceFile, err := os.Open(src)
 	if err != nil {
-		return err
+		return fmt.Errorf("open source file %s: %w", src, err)
 	}
 	defer sourceFile.Close()
 
 	destinationFile, err := os.Create(dst)
 	if err != nil {
-		return err
+		return fmt.Errorf("create destination file %s: %w", dst, err)
 	}
 	defer destinationFile.Close()
 
 	_, err = io.Copy(destinationFile, sourceFile)
 	if err != nil {
-		return err
+		return fmt.Errorf("copy to %s: %w", dst, err)
 	}
 
-	// Preserve the file permissions from the source file
 	err = os.Chmod(dst, sourceFileStat.Mode())
 	if err != nil {
-		return err
+		return fmt.Errorf("chmod %s: %w", dst, err)
 	}
 
 	return nil
@@ -69,7 +68,7 @@ func WriteEmbeddedFile(fsys fs.FS, srcPath, dstPath string, mode os.FileMode) er
 		return fmt.Errorf("reading embedded file %s: %w", srcPath, err)
 	}
 	if err := os.WriteFile(dstPath, data, mode); err != nil {
-		return err
+		return fmt.Errorf("write file %s: %w", dstPath, err)
 	}
 	return os.Chmod(dstPath, mode)
 }
@@ -78,11 +77,11 @@ func WriteEmbeddedFile(fsys fs.FS, srcPath, dstPath string, mode os.FileMode) er
 func WriteEmbeddedDir(fsys fs.FS, srcDir, dstDir string) error {
 	return fs.WalkDir(fsys, srcDir, func(path string, d fs.DirEntry, err error) error {
 		if err != nil {
-			return err
+			return fmt.Errorf("walk embedded dir: %w", err)
 		}
 		relPath, err := filepath.Rel(srcDir, path)
 		if err != nil {
-			return err
+			return fmt.Errorf("compute relative path for %s: %w", path, err)
 		}
 		target := filepath.Join(dstDir, relPath)
 
@@ -99,19 +98,19 @@ func WriteEmbeddedDir(fsys fs.FS, srcDir, dstDir string) error {
 func CopyDir(src, dst string) error {
 	srcInfo, err := os.Stat(src)
 	if err != nil {
-		return err
+		return fmt.Errorf("stat source dir %s: %w", src, err)
 	}
 	if !srcInfo.IsDir() {
 		return fmt.Errorf("%s is not a directory", src)
 	}
 
 	if err := os.MkdirAll(dst, 0o755); err != nil {
-		return err
+		return fmt.Errorf("create destination dir %s: %w", dst, err)
 	}
 
 	entries, err := os.ReadDir(src)
 	if err != nil {
-		return err
+		return fmt.Errorf("read source dir %s: %w", src, err)
 	}
 
 	for _, entry := range entries {
@@ -120,11 +119,11 @@ func CopyDir(src, dst string) error {
 
 		if entry.IsDir() {
 			if err := CopyDir(srcPath, dstPath); err != nil {
-				return err
+				return fmt.Errorf("copy subdir %s: %w", entry.Name(), err)
 			}
 		} else {
 			if err := CopyFile(srcPath, dstPath); err != nil {
-				return err
+				return fmt.Errorf("copy file %s: %w", entry.Name(), err)
 			}
 		}
 	}
@@ -143,7 +142,7 @@ func RemovePathIfExists(targetPath string) error {
 		if os.IsNotExist(err) {
 			return nil
 		}
-		return err
+		return fmt.Errorf("lstat %s: %w", targetPath, err)
 	}
 
 	if info.IsDir() {
@@ -157,7 +156,7 @@ func RemovePathIfExists(targetPath string) error {
 func FileContainsIncludeMakefileCommon(makefilePath string) (bool, error) {
 	data, err := os.ReadFile(makefilePath)
 	if err != nil {
-		return false, err
+		return false, fmt.Errorf("read %s: %w", makefilePath, err)
 	}
 	contents := string(data)
 	// We keep this simple to avoid regex: look for lines with 'include' and 'Makefile-common'
@@ -177,7 +176,7 @@ func FileContainsIncludeMakefileCommon(makefilePath string) (bool, error) {
 func PrependLineToFile(filePath, line string) error {
 	data, err := os.ReadFile(filePath)
 	if err != nil {
-		return err
+		return fmt.Errorf("read %s: %w", filePath, err)
 	}
 
 	mode := os.FileMode(0o644)
@@ -208,7 +207,6 @@ func WriteYAMLWithIndent(data interface{}, filePath string) error {
 		return fmt.Errorf("failed to encode YAML to %s: %w", filePath, err)
 	}
 
-	// Set file permissions to 0644
 	if err := os.Chmod(filePath, 0o644); err != nil {
 		return fmt.Errorf("failed to set permissions on %s: %w", filePath, err)
 	}

src/internal/fileutils/skills.go

@@ -10,6 +10,7 @@ import (
 
 var skillTargets = []string{".claude", ".cursor"}
 
+// InstallSkills copies all embedded skill directories into the .claude and .cursor skill directories under the given repository root.
 func InstallSkills(repoRoot string) error {
 	entries, err := fs.ReadDir(embedded.Skills, "skills")
 	if err != nil {