cover html-limited bot metadata behavior in deployed PPR paths#94314
Open
gnoff wants to merge 1 commit into
Open
cover html-limited bot metadata behavior in deployed PPR paths#94314gnoff wants to merge 1 commit into
gnoff wants to merge 1 commit into
Conversation
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 6a614ae |
Contributor
Failing test suitesCommit: 6a614ae | About building and testing Next.js
Expand output● app-dir - metadata-streaming › should send a streaming response for bot Google-PageRenderer without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Google-InspectionTool without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot AdsBot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Storebot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot googleweblight without known head limitations
Expand output● cache-components PPR bot static generation bypass › should stream metadata for bot Google-PageRenderer without known head limitations
Expand output● cache-components PPR bot static generation bypass › should stream metadata for bot Google-PageRenderer without known head limitations
Expand output● app-dir - metadata-streaming › should send a streaming response for bot Google-PageRenderer without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Google-InspectionTool without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot AdsBot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Storebot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot googleweblight without known head limitations
Expand output● cache-components PPR bot static generation bypass › should stream metadata for bot Googlebot without known head limitations ● cache-components PPR bot static generation bypass › should stream metadata for bot Google-PageRenderer without known head limitations ● cache-components PPR customized htmlLimitedBots › should block metadata for a configured html limited bot ● cache-components PPR customized htmlLimitedBots › should stream metadata for Googlebot when it is not in the configured rule
Expand output● app-dir - metadata-streaming › should send a streaming response for bot Google-PageRenderer without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Google-InspectionTool without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot AdsBot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Storebot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot googleweblight without known head limitations
Expand output● hmr-intercept-routes › should update intercept routes via HMR
Expand output● app-dir - metadata-streaming › should send a streaming response for bot Google-PageRenderer without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Google-InspectionTool without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot AdsBot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Storebot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot googleweblight without known head limitations
Expand output● cache-components PPR bot static generation bypass › should stream metadata for bot Googlebot without known head limitations ● cache-components PPR bot static generation bypass › should stream metadata for bot Google-PageRenderer without known head limitations ● cache-components PPR customized htmlLimitedBots › should block metadata for a configured html limited bot ● cache-components PPR customized htmlLimitedBots › should stream metadata for Googlebot when it is not in the configured rule
Expand output● cache-components PPR bot static generation bypass › should stream metadata for bot Google-PageRenderer without known head limitations
Expand output● app-dir - metadata-streaming › should send a streaming response for bot Google-PageRenderer without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Google-InspectionTool without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot AdsBot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Storebot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot googleweblight without known head limitations
Expand output● cache-components PPR bot static generation bypass › should stream metadata for bot Googlebot without known head limitations ● cache-components PPR bot static generation bypass › should stream metadata for bot Google-PageRenderer without known head limitations ● cache-components PPR customized htmlLimitedBots › should block metadata for a configured html limited bot ● cache-components PPR customized htmlLimitedBots › should stream metadata for Googlebot when it is not in the configured rule
Expand output● app-dir - metadata-streaming › should send a streaming response for bot Google-PageRenderer without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Google-InspectionTool without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot AdsBot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot Storebot-Google without known head limitations ● app-dir - metadata-streaming › should send a streaming response for bot googleweblight without known head limitations |
gnoff
force-pushed
the
jstory/failing-tests-html-bot-streaming
branch
from
4ae34f8 to
6a614ae
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| }) | ||
| }) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Test asserts streaming (metadata in body) for html-limited Google crawlers that actually receive a blocking response (metadata in head), causing the new test cases to fail.
| headers: { | ||
| 'user-agent': userAgent, | ||
| }, | ||
| }) |
Contributor
There was a problem hiding this comment.
Test asserts streaming metadata for 'Google-PageRenderer', but it is classified as an html-limited (blocking) bot, so the assertion is inverted and will fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.