Skip to content

Commit 729ae01

Browse files
authored
Fix navigable lookup algorithms and completion steps parallelism (#301)
1 parent e7c1ef5 commit 729ae01

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

‎index.bs‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ To <dfn>notify documents of a tool change</dfn> given a {{Document}} |tool owner
350350
1. [=Assert=]: these steps are running [=in parallel=].
351351

352352
1. Let |navigablesToNotify| be |tool owner|'s [=node navigable=]'s [=navigable/traversable
353-
navigable=]'s [=Document/inclusive descendant navigables=].
353+
navigable=]'s [=navigable/active document=]'s [=Document/inclusive descendant navigables=].
354354

355355
1. [=list/For each=] |navigable| of |navigablesToNotify|:
356356

@@ -485,7 +485,7 @@ internal value=] |uuid|, are as follows:
485485
Issue: Support more granular errors; here we should return something that prompts the caller to
486486
reject its {{Promise}} with a "{{DataError}}" {{DOMException}}.
487487

488-
1. If |inputObject| [=Object type|is not an Object=] is false, then run |completionSteps| given null
488+
1. If |inputObject| [=Object type|is not an Object=], then run |completionSteps| given null
489489
and false, and abort these steps.
490490

491491
1. [=Fire an event=] named {{ModelContext/toolactivated}} at |targetDocument|'s [=Document/associated
@@ -858,7 +858,7 @@ The <dfn method for=ModelContext>getTools(<var>options</var>)</dfn> method steps
858858
1. Let |tools| be an empty [=list=] of {{RegisteredTool}} dictionaries.
859859

860860
1. Let |navigables| be |toolRequestor|'s [=node navigable=]'s [=navigable/traversable
861-
navigable=]'s [=Document/inclusive descendant navigables=].
861+
navigable=]'s [=navigable/active document=]'s [=Document/inclusive descendant navigables=].
862862

863863
1. [=list/For each=] |navigable| of |navigables|:
864864

@@ -1041,13 +1041,11 @@ The <dfn method for=ModelContext>executeTool(<var>tool</var>, <var>inputObject</
10411041
Issue: Support more granular errors than "{{UnknownError}}", based on each failure case.
10421042

10431043
1. Let |completionSteps| be an algorithm that takes a [=string=]-or-null |result| and a
1044-
[=boolean=] |success|, and runs the following steps:
1045-
1046-
1. [=Assert=]: these steps are running [=in parallel=].
1044+
[=boolean=] |success|, and runs the following steps [=in parallel=]:
10471045

10481046
1. If |targetDocument|'s [=node navigable=]'s [=navigable/traversable navigable=]'s
1049-
[=traversable navigable/pending tool executions map=][|uuid|] does not [=map/exist=], then
1050-
return.
1047+
[=traversable navigable/pending tool executions map=][|uuid|] does not [=map/exist=],
1048+
then return.
10511049

10521050
<div class=note id=pending-execution-removal-race>
10531051
<p>It is possible that a pending execution identified by |uuid| no longer exists. This can

0 commit comments

Comments
 (0)