Fill postal code from block-less re-query when dadata lacks it - #521
Open
ekateluv wants to merge 2 commits into
Open
Fill postal code from block-less re-query when dadata lacks it#521ekateluv wants to merge 2 commits into
ekateluv wants to merge 2 commits into
Conversation
…s it Dadata house-level suggestions for buildings with a block (к N) often return postal_code=null, leaving the required postcode field empty and blocking checkout. When that happens, re-query dadata without the block part — the building index is the same.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 17 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Accept the fallback postcode only when the returned suggestion matches the selected street and house, so a fuzzy match can't inject a wrong index. Extract dadataSuggest() shared by all three call sites.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что происходит; кому и зачем нужно:
после выбора адреса с корпусом из подсказок дадаты поле «Почтовый индекс» оставалось пустым (dadata suggest отдаёт
postal_code: nullдля многих домов с корпусом) и блокировало оформление заказа. Теперь в этом случае индекс добирается повторным запросом к дадате без корпуса (у здания индекс один), с проверкой, что вернулась та же улица и дом.Что поменялось для пользователей:
При выборе адреса вида «Огородный пр-д, д 5 к 2» индекс подставляется автоматически, заказ оформляется без ручного ввода индекса.
Как проверял/а:
на тестовом
Чеклист ревью:
Перед мержем не забудь проверить:
Опционально (но важно для изменений в инфраструктуру):