Skip to content

Update demo panels - #1247

Open
clarasb wants to merge 5 commits into
mainfrom
clarasb/xxx-update_chartlets_0.2.1
Open

Update demo panels#1247
clarasb wants to merge 5 commits into
mainfrom
clarasb/xxx-update_chartlets_0.2.1

Conversation

@clarasb

@clarasb clarasb commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the demo panels:

  • fixes a xarray warning in panel_spectrum.py
  • adds a progress component to panel_spectrum.py and panel_histo2d.py
Screenshot 2026-08-14 161035

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • Test coverage remains or increases (target 100%)

@clarasb
clarasb marked this pull request as ready for review August 20, 2026 07:33
@clarasb
clarasb requested review from forman and freds-dev August 20, 2026 07:33

@freds-dev freds-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After drawing a circle and then opening the histogram sidebar tab I see the following error. There is no option to choose variables or a histogram. : TypeError: CircularProgress.__init__() got an unexpected keyword argument 'hidden'.

I guess we should update the minimum chartlets version to 0.2.1? That solved the issue for me.

@clarasb clarasb self-assigned this Aug 20, 2026
@clarasb
clarasb requested a review from freds-dev August 20, 2026 16:11
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (e3f5a2d) to head (aeb1d9e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
- Coverage   89.43%   89.42%   -0.01%     
==========================================
  Files         276      276              
  Lines       21428    21428              
==========================================
- Hits        19165    19163       -2     
- Misses       2263     2265       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants