Repository navigation
fix: Clippy warnings: string formatting, match arms, unused imports, … #319
yonasAnnotations
332 warnings and 1 notice
|
struct pattern is not needed for a unit variant:
backpack/cli/src/main.rs#L249
warning: struct pattern is not needed for a unit variant
--> backpack/cli/src/main.rs:249:24
|
249 | Commands::Hello {} => {
| ^^^ help: remove the struct pattern
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unneeded_struct_pattern
= note: `-W clippy::unneeded-struct-pattern` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unneeded_struct_pattern)]`
|
|
adding items after statements is confusing, since items exist from the start of the scope:
backpack/cli/src/main.rs#L74
warning: adding items after statements is confusing, since items exist from the start of the scope
--> backpack/cli/src/main.rs:74:5
|
74 | const PROJECT_DESC: &str = env!("CARGO_PKG_DESCRIPTION");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements
|
|
adding items after statements is confusing, since items exist from the start of the scope:
backpack/cli/src/main.rs#L73
warning: adding items after statements is confusing, since items exist from the start of the scope
--> backpack/cli/src/main.rs:73:5
|
73 | const PROJECT_NAME: &str = env!("CARGO_PKG_NAME");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements
= note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`
|
|
this function has too many lines (162/100):
backpack/cli/src/main.rs#L16
warning: this function has too many lines (162/100)
--> backpack/cli/src/main.rs:16:7
|
16 | async fn main() -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_lines
= note: `-W clippy::too-many-lines` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::too_many_lines)]`
|
|
this argument is passed by value, but not consumed in the function body:
backpack/cli/src/commands/merge/mod.rs#L12
warning: this argument is passed by value, but not consumed in the function body
--> backpack/cli/src/commands/merge/mod.rs:12:18
|
12 | pub fn run(repo: String) -> anyhow::Result<()> {
| ^^^^^^ help: consider changing the type to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value
|
|
matching over `()` is more explicit:
backpack/cli/src/commands/maintain/mod.rs#L66
warning: matching over `()` is more explicit
--> backpack/cli/src/commands/maintain/mod.rs:66:16
|
66 | Ok(_) => {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ignored_unit_patterns
= note: `-W clippy::ignored-unit-patterns` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::ignored_unit_patterns)]`
|
|
variables can be used directly in the `format!` string:
backpack/cli/src/commands/maintain/mod.rs#L61
warning: variables can be used directly in the `format!` string
--> backpack/cli/src/commands/maintain/mod.rs:61:17
|
61 | / eprintln!(
62 | | "Failed to complete full release cleanup for {}: {}",
63 | | repo, e
64 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::uninlined_format_args)]`
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
backpack/cli/src/commands/maintain/mod.rs#L59
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> backpack/cli/src/commands/maintain/mod.rs:59:9
|
59 | / match github::delete_all_releases(&client, &repo) {
60 | | Err(e) => {
61 | | eprintln!(
62 | | "Failed to complete full release cleanup for {}: {}",
... |
74 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else
= note: `-W clippy::single-match-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::single_match_else)]`
help: try
|
59 ~ if let Err(e) = github::delete_all_releases(&client, &repo) {
60 + eprintln!(
61 + "Failed to complete full release cleanup for {}: {}",
62 + repo, e
63 + );
64 + } else {
65 + println!("Deleted all releases and tags");
66 +
67 + // Then create the new release
68 + github::create_release(&client, &repo)?;
69 +
70 + println!("Created new release");
71 + }
|
|
|
this argument is passed by value, but not consumed in the function body:
backpack/cli/src/commands/maintain/mod.rs#L10
warning: this argument is passed by value, but not consumed in the function body
--> backpack/cli/src/commands/maintain/mod.rs:10:18
|
10 | pub fn run(repo: String, action: &Option<String>) -> anyhow::Result<()> {
| ^^^^^^ help: consider changing the type to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
|
|
it is more idiomatic to use `Option<&T>` instead of `&Option<T>`:
backpack/cli/src/commands/maintain/mod.rs#L10
warning: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> backpack/cli/src/commands/maintain/mod.rs:10:1
|
10 | pub fn run(repo: String, action: &Option<String>) -> anyhow::Result<()> {
| ^ --------------- help: change this to: `Option<&String>`
| _|
| |
11 | | // Capture backtraces for all errors
12 | | Hooks::new()
13 | | .report_creation_hook(BacktraceCollector::new_from_env())
... |
79 | | Ok(())
80 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ref_option
= note: `-W clippy::ref-option` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::ref_option)]`
|
|
multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-result`: 0.3.4, 0.4.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-result`: 0.3.4, 0.4.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-link`: 0.1.3, 0.2.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-link`: 0.1.3, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-core`: 0.61.2, 0.62.2:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-core`: 0.61.2, 0.62.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror`: 1.0.69, 2.0.18:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `thiserror`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `getrandom`: 0.2.17, 0.3.4:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `getrandom`: 0.2.17, 0.3.4
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `console`: 0.15.11, 0.16.2:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `console`: 0.15.11, 0.16.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
= note: `-W clippy::multiple-crate-versions` implied by `-W clippy::cargo`
= help: to override `-W clippy::cargo` add `#[allow(clippy::multiple_crate_versions)]`
|
|
struct pattern is not needed for a unit variant:
backpack/cli/src/main.rs#L249
warning: struct pattern is not needed for a unit variant
--> backpack/cli/src/main.rs:249:24
|
249 | Commands::Hello {} => {
| ^^^ help: remove the struct pattern
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unneeded_struct_pattern
= note: `-W clippy::unneeded-struct-pattern` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unneeded_struct_pattern)]`
|
|
adding items after statements is confusing, since items exist from the start of the scope:
backpack/cli/src/main.rs#L74
warning: adding items after statements is confusing, since items exist from the start of the scope
--> backpack/cli/src/main.rs:74:5
|
74 | const PROJECT_DESC: &str = env!("CARGO_PKG_DESCRIPTION");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements
|
|
adding items after statements is confusing, since items exist from the start of the scope:
backpack/cli/src/main.rs#L73
warning: adding items after statements is confusing, since items exist from the start of the scope
--> backpack/cli/src/main.rs:73:5
|
73 | const PROJECT_NAME: &str = env!("CARGO_PKG_NAME");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements
= note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`
|
|
this function has too many lines (162/100):
backpack/cli/src/main.rs#L16
warning: this function has too many lines (162/100)
--> backpack/cli/src/main.rs:16:7
|
16 | async fn main() -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_lines
= note: `-W clippy::too-many-lines` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::too_many_lines)]`
|
|
this argument is passed by value, but not consumed in the function body:
backpack/cli/src/commands/merge/mod.rs#L12
warning: this argument is passed by value, but not consumed in the function body
--> backpack/cli/src/commands/merge/mod.rs:12:18
|
12 | pub fn run(repo: String) -> anyhow::Result<()> {
| ^^^^^^ help: consider changing the type to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value
|
|
matching over `()` is more explicit:
backpack/cli/src/commands/maintain/mod.rs#L66
warning: matching over `()` is more explicit
--> backpack/cli/src/commands/maintain/mod.rs:66:16
|
66 | Ok(_) => {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ignored_unit_patterns
= note: `-W clippy::ignored-unit-patterns` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::ignored_unit_patterns)]`
|
|
variables can be used directly in the `format!` string:
backpack/cli/src/commands/maintain/mod.rs#L61
warning: variables can be used directly in the `format!` string
--> backpack/cli/src/commands/maintain/mod.rs:61:17
|
61 | / eprintln!(
62 | | "Failed to complete full release cleanup for {}: {}",
63 | | repo, e
64 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::uninlined_format_args)]`
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
backpack/cli/src/commands/maintain/mod.rs#L59
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> backpack/cli/src/commands/maintain/mod.rs:59:9
|
59 | / match github::delete_all_releases(&client, &repo) {
60 | | Err(e) => {
61 | | eprintln!(
62 | | "Failed to complete full release cleanup for {}: {}",
... |
74 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else
= note: `-W clippy::single-match-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::single_match_else)]`
help: try
|
59 ~ if let Err(e) = github::delete_all_releases(&client, &repo) {
60 + eprintln!(
61 + "Failed to complete full release cleanup for {}: {}",
62 + repo, e
63 + );
64 + } else {
65 + println!("Deleted all releases and tags");
66 +
67 + // Then create the new release
68 + github::create_release(&client, &repo)?;
69 +
70 + println!("Created new release");
71 + }
|
|
|
this argument is passed by value, but not consumed in the function body:
backpack/cli/src/commands/maintain/mod.rs#L10
warning: this argument is passed by value, but not consumed in the function body
--> backpack/cli/src/commands/maintain/mod.rs:10:18
|
10 | pub fn run(repo: String, action: &Option<String>) -> anyhow::Result<()> {
| ^^^^^^ help: consider changing the type to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
|
|
it is more idiomatic to use `Option<&T>` instead of `&Option<T>`:
backpack/cli/src/commands/maintain/mod.rs#L10
warning: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> backpack/cli/src/commands/maintain/mod.rs:10:1
|
10 | pub fn run(repo: String, action: &Option<String>) -> anyhow::Result<()> {
| ^ --------------- help: change this to: `Option<&String>`
| _|
| |
11 | | // Capture backtraces for all errors
12 | | Hooks::new()
13 | | .report_creation_hook(BacktraceCollector::new_from_env())
... |
79 | | Ok(())
80 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ref_option
= note: `-W clippy::ref-option` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::ref_option)]`
|
|
multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-result`: 0.3.4, 0.4.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-result`: 0.3.4, 0.4.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-link`: 0.1.3, 0.2.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-link`: 0.1.3, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-core`: 0.61.2, 0.62.2:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `windows-core`: 0.61.2, 0.62.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror`: 1.0.69, 2.0.18:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `thiserror`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `getrandom`: 0.2.17, 0.3.4:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `getrandom`: 0.2.17, 0.3.4
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `console`: 0.15.11, 0.16.2:
backpack/cli/src/main.rs#L1
warning: multiple versions for dependency `console`: 0.15.11, 0.16.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
= note: `-W clippy::multiple-crate-versions` implied by `-W clippy::cargo`
= help: to override `-W clippy::cargo` add `#[allow(clippy::multiple_crate_versions)]`
|
|
unused `async` for function with no await statements:
backpack/lib/src/plugins/mod.rs#L77
warning: unused `async` for function with no await statements
--> backpack/lib/src/plugins/mod.rs:77:5
|
77 | / pub async fn run_script(&self, event: &Event) -> Result<()> {
78 | | fn get_rhai_engine() -> Engine {
79 | | let mut engine = Engine::new();
... |
138 | | }
| |_____^
|
= help: consider removing the `async` from this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unused_async
= note: `-W clippy::unused-async` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`
|
|
useless use of `vec!`:
backpack/lib/src/github/tests.rs#L292
warning: useless use of `vec!`
--> backpack/lib/src/github/tests.rs:292:16
|
292 | let runs = vec![
| ________________^
293 | | serde_json::from_value::<WorkflowRun>(create_workflow_run_json(
294 | | 1,
295 | | "CI",
... |
327 | | .unwrap(),
328 | | ];
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_vec
= note: `-W clippy::useless-vec` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_vec)]`
help: you can use an array directly
|
292 ~ let runs = [serde_json::from_value::<WorkflowRun>(create_workflow_run_json(
293 + 1,
294 + "CI",
295 + "completed",
296 + Some("success"),
297 + ))
298 + .unwrap(),
299 + serde_json::from_value::<WorkflowRun>(create_workflow_run_json(
300 + 2,
301 + "Tests",
302 + "completed",
303 + Some("failure"),
304 + ))
305 + .unwrap(),
306 + serde_json::from_value::<WorkflowRun>(create_workflow_run_json(
307 + 3,
308 + "Build",
309 + "completed",
310 + Some("timed_out"),
311 + ))
312 + .unwrap(),
313 + serde_json::from_value::<WorkflowRun>(create_workflow_run_json(
314 + 4,
315 + "Lint",
316 + "completed",
317 + Some("cancelled"),
318 + ))
319 + .unwrap(),
320 + serde_json::from_value::<WorkflowRun>(create_workflow_run_json(
321 + 5,
322 + "Deploy",
323 + "in_progress",
324 + None,
325 + ))
326 ~ .unwrap()];
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/plugins/tests.rs#L208
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/plugins/tests.rs:208:9
|
208 | println!("{:#?}", result);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
208 - println!("{:#?}", result);
208 + println!("{result:#?}");
|
|
|
module has the same name as its containing module:
backpack/lib/src/plugins/tests.rs#L2
warning: module has the same name as its containing module
--> backpack/lib/src/plugins/tests.rs:2:1
|
2 | / mod tests {
3 | | use std::{fs, io::Write, path::Path, path::PathBuf};
4 | | use tempfile::tempdir;
... |
234 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#module_inception
= note: `-W clippy::module-inception` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::module_inception)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/plugins/mod.rs#L215
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/plugins/mod.rs:215:1
|
215 | pub fn discover_plugins() -> Result<Vec<Plugin>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/plugins/mod.rs#L77
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/plugins/mod.rs:77:5
|
77 | pub async fn run_script(&self, event: &Event) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/plugins/mod.rs#L52
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/plugins/mod.rs:52:5
|
52 | pub fn from_dir(path: &Path) -> Result<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/plugins/color.rs#L25
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/plugins/color.rs:25:13
|
25 | println!("{}", message);
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
25 - println!("{}", message);
25 + println!("{message}");
|
|
|
this function's return value is unnecessary:
backpack/lib/src/plugins/color.rs#L7
warning: this function's return value is unnecessary
--> backpack/lib/src/plugins/color.rs:7:1
|
7 | pub fn cprint(message: &str, color_name: &str) -> Result<(), Box<EvalAltResult>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
help: remove the return type...
|
7 - pub fn cprint(message: &str, color_name: &str) -> Result<(), Box<EvalAltResult>> {
7 + pub fn cprint(message: &str, color_name: &str) -> () {
|
help: ...and then remove returned values
|
28- Ok(())
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L777
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:777:9
|
777 | format!("… {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
777 - format!("… {}", m)
777 + format!("… {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L773
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:773:9
|
773 | format!("🔍 {}", m)
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
773 - format!("🔍 {}", m)
773 + format!("🔍 {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L769
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:769:9
|
769 | format!("⠿ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
769 - format!("⠿ {}", m)
769 + format!("⠿ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L764
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:764:9
|
764 | format!("✔ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
764 - format!("✔ {}", m)
764 + format!("✔ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L759
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:759:9
|
759 | format!("✔ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
759 - format!("✔ {}", m)
759 + format!("✔ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L754
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:754:9
|
754 | format!("→ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
754 - format!("→ {}", m)
754 + format!("→ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L749
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:749:9
|
749 | format!("› {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
749 - format!("› {}", m)
749 + format!("› {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L744
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:744:9
|
744 | format!("ℹ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
744 - format!("ℹ {}", m)
744 + format!("ℹ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L739
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:739:9
|
739 | format!("✗ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
739 - format!("✗ {}", m)
739 + format!("✗ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L734
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:734:9
|
734 | format!("⚠ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
734 - format!("⚠ {}", m)
734 + format!("⚠ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L729
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:729:9
|
729 | format!("✔ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
729 - format!("✔ {}", m)
729 + format!("✔ {m}")
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L720
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:720:46
|
720 | /// Quiet-mode suppression is handled by the FormatLogger trait.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
720 - /// Quiet-mode suppression is handled by the FormatLogger trait.
720 + /// Quiet-mode suppression is handled by the `FormatLogger` trait.
|
|
|
`to_string` applied to a type that implements `Display` in `println!` args:
backpack/lib/src/log.rs#L712
warning: `to_string` applied to a type that implements `Display` in `println!` args
--> backpack/lib/src/log.rs:712:36
|
712 | _ => println!("{}", obj.to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `eprintln!` args:
backpack/lib/src/log.rs#L711
warning: `to_string` applied to a type that implements `Display` in `eprintln!` args
--> backpack/lib/src/log.rs:711:43
|
711 | "error" => eprintln!("{}", obj.to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#to_string_in_format_args
= note: `-W clippy::to-string-in-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::to_string_in_format_args)]`
|
|
unused `self` argument:
backpack/lib/src/log.rs#L701
warning: unused `self` argument
--> backpack/lib/src/log.rs:701:18
|
701 | fn emit_json(&self, level: &str, message: &str) {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unused_self
= note: `-W clippy::unused-self` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_self)]`
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L690
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:690:51
|
690 | /// - Builds a structured JSON object using serde_json
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
690 - /// - Builds a structured JSON object using serde_json
690 + /// - Builds a structured JSON object using `serde_json`
|
|
|
this could be a `const fn`:
backpack/lib/src/log.rs#L462
warning: this could be a `const fn`
--> backpack/lib/src/log.rs:462:5
|
462 | / pub fn new(inner: L, format: LogFormat) -> Self {
463 | | Self {
464 | | inner,
465 | | tasks: RefCell::new(Vec::new()),
... |
469 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_const_for_fn
= note: `-W clippy::missing-const-for-fn` implied by `-W clippy::nursery`
= help: to override `-W clippy::nursery` add `#[allow(clippy::missing_const_for_fn)]`
help: make the function `const`
|
462 | pub const fn new(inner: L, format: LogFormat) -> Self {
| +++++
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L448
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:448:47
|
448 | /// Stack of active step spans created by step()
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
448 - /// Stack of active step spans created by step()
448 + /// Stack of active step spans created by `step()`
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L445
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:445:47
|
445 | /// Stack of active task spans created by intro()
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
445 - /// Stack of active task spans created by intro()
445 + /// Stack of active task spans created by `intro()`
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L442
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:442:49
|
442 | /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
442 - /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
442 + /// The underlying formatter (SimpleLogger, `ModernLogger`, etc.)
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L442
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:442:35
|
442 | /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
442 - /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
442 + /// The underlying formatter (`SimpleLogger`, ModernLogger, etc.)
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L437
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:437:51
|
437 | /// - Nested task spans via intro() / outro() / done()
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
437 - /// - Nested task spans via intro() / outro() / done()
437 + /// - Nested task spans via intro() / outro() / `done()`
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L437
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:437:41
|
437 | /// - Nested task spans via intro() / outro() / done()
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
437 - /// - Nested task spans via intro() / outro() / done()
437 + /// - Nested task spans via intro() / `outro()` / done()
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L437
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:437:31
|
437 | /// - Nested task spans via intro() / outro() / done()
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
437 - /// - Nested task spans via intro() / outro() / done()
437 + /// - Nested task spans via `intro()` / outro() / done()
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L380
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:380:44
|
380 | /// All quiet-mode logic is handled in the FormatLogger layer.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
380 - /// All quiet-mode logic is handled in the FormatLogger layer.
380 + /// All quiet-mode logic is handled in the `FormatLogger` layer.
|
|
|
unused `async` for function with no await statements:
backpack/lib/src/plugins/mod.rs#L77
warning: unused `async` for function with no await statements
--> backpack/lib/src/plugins/mod.rs:77:5
|
77 | / pub async fn run_script(&self, event: &Event) -> Result<()> {
78 | | fn get_rhai_engine() -> Engine {
79 | | let mut engine = Engine::new();
... |
138 | | }
| |_____^
|
= help: consider removing the `async` from this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unused_async
= note: `-W clippy::unused-async` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L353
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:353:13
|
353 | format!("\x1b[36m⠿\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
353 - format!("\x1b[36m⠿\x1b[0m {}", m)
353 + format!("\x1b[36m⠿\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L351
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:351:13
|
351 | format!("* {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
351 - format!("* {}", m)
351 + format!("* {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L345
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:345:9
|
345 | format!("✓ Done! {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
345 - format!("✓ Done! {}", m)
345 + format!("✓ Done! {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L340
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:340:9
|
340 | format!("✓ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
340 - format!("✓ {}", m)
340 + format!("✓ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L335
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:335:9
|
335 | format!("→ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
335 - format!("→ {}", m)
335 + format!("→ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L327
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:327:13
|
327 | format!(" {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
327 - format!(" {}", m)
327 + format!(" {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L321
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:321:9
|
321 | format!(" {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
321 - format!(" {}", m)
321 + format!(" {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L315
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:315:13
|
315 | format!("\x1b[31m✗\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
315 - format!("\x1b[31m✗\x1b[0m {}", m)
315 + format!("\x1b[31m✗\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L313
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:313:13
|
313 | format!("X {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
313 - format!("X {}", m)
313 + format!("X {m}")
|
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/plugins/mod.rs#L215
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/plugins/mod.rs:215:1
|
215 | pub fn discover_plugins() -> Result<Vec<Plugin>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L306
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:306:13
|
306 | format!("\x1b[33m⚠\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
306 - format!("\x1b[33m⚠\x1b[0m {}", m)
306 + format!("\x1b[33m⚠\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L304
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:304:13
|
304 | format!("! {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
304 - format!("! {}", m)
304 + format!("! {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L297
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:297:13
|
297 | format!("\x1b[32m✔\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
297 - format!("\x1b[32m✔\x1b[0m {}", m)
297 + format!("\x1b[32m✔\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L295
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:295:13
|
295 | format!("+ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
295 - format!("+ {}", m)
295 + format!("+ {m}")
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L285
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:285:46
|
285 | /// Quiet-mode suppression is handled by the FormatLogger trait.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
285 - /// Quiet-mode suppression is handled by the FormatLogger trait.
285 + /// Quiet-mode suppression is handled by the `FormatLogger` trait.
|
|
|
doc list item overindented:
backpack/lib/src/log.rs#L123
warning: doc list item overindented
--> backpack/lib/src/log.rs:123:5
|
123 | /// • wrap the raw formatting
| ^^^^^^^^ help: try using ` ` (4 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_overindented_list_items
|
|
doc list item overindented:
backpack/lib/src/log.rs#L122
warning: doc list item overindented
--> backpack/lib/src/log.rs:122:5
|
122 | /// • automatically apply quiet-mode suppression
| ^^^^^^^^ help: try using ` ` (4 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_overindented_list_items
= note: `-W clippy::doc-overindented-list-items` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::doc_overindented_list_items)]`
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L111
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:111:43
|
111 | /// how long the task took when outro() / done() is called.
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
111 - /// how long the task took when outro() / done() is called.
111 + /// how long the task took when outro() / `done()` is called.
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L111
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:111:33
|
111 | /// how long the task took when outro() / done() is called.
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
= note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]`
help: try
|
111 - /// how long the task took when outro() / done() is called.
111 + /// how long the task took when `outro()` / done() is called.
|
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/plugins/mod.rs#L77
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/plugins/mod.rs:77:5
|
77 | pub async fn run_script(&self, event: &Event) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/plugins/mod.rs#L52
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/plugins/mod.rs:52:5
|
52 | pub fn from_dir(path: &Path) -> Result<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/log.rs#L36
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/log.rs:36:1
|
36 | pub fn init() {
| ^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/log.rs:73:41
|
73 | && ["debug", "trace"].contains(&std::env::var("RUST_LOG").unwrap().to_lowercase().as_str())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/log.rs#L32
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/log.rs:32:1
|
32 | pub fn log() -> &'static Arc<dyn ScreenLogger + Send + Sync> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/log.rs:33:5
|
33 | LOGGER.get().expect("Logger not initialized")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/plugins/color.rs#L25
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/plugins/color.rs:25:13
|
25 | println!("{}", message);
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
25 - println!("{}", message);
25 + println!("{message}");
|
|
|
this function's return value is unnecessary:
backpack/lib/src/plugins/color.rs#L7
warning: this function's return value is unnecessary
--> backpack/lib/src/plugins/color.rs:7:1
|
7 | pub fn cprint(message: &str, color_name: &str) -> Result<(), Box<EvalAltResult>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
help: remove the return type...
|
7 - pub fn cprint(message: &str, color_name: &str) -> Result<(), Box<EvalAltResult>> {
7 + pub fn cprint(message: &str, color_name: &str) -> () {
|
help: ...and then remove returned values
|
28- Ok(())
|
|
|
usage of wildcard import:
backpack/lib/src/plugins/color.rs#L1
warning: usage of wildcard import
--> backpack/lib/src/plugins/color.rs:1:5
|
1 | use colored::*;
| ^^^^^^^^^^ help: try: `colored::{Color, Colorize}`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#wildcard_imports
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L777
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:777:9
|
777 | format!("… {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
777 - format!("… {}", m)
777 + format!("… {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L773
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:773:9
|
773 | format!("🔍 {}", m)
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
773 - format!("🔍 {}", m)
773 + format!("🔍 {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L769
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:769:9
|
769 | format!("⠿ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
769 - format!("⠿ {}", m)
769 + format!("⠿ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L764
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:764:9
|
764 | format!("✔ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
764 - format!("✔ {}", m)
764 + format!("✔ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L759
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:759:9
|
759 | format!("✔ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
759 - format!("✔ {}", m)
759 + format!("✔ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L754
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:754:9
|
754 | format!("→ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
754 - format!("→ {}", m)
754 + format!("→ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L749
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:749:9
|
749 | format!("› {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
749 - format!("› {}", m)
749 + format!("› {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L744
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:744:9
|
744 | format!("ℹ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
744 - format!("ℹ {}", m)
744 + format!("ℹ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L739
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:739:9
|
739 | format!("✗ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
739 - format!("✗ {}", m)
739 + format!("✗ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L734
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:734:9
|
734 | format!("⚠ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
734 - format!("⚠ {}", m)
734 + format!("⚠ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L729
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:729:9
|
729 | format!("✔ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
729 - format!("✔ {}", m)
729 + format!("✔ {m}")
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L720
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:720:46
|
720 | /// Quiet-mode suppression is handled by the FormatLogger trait.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
720 - /// Quiet-mode suppression is handled by the FormatLogger trait.
720 + /// Quiet-mode suppression is handled by the `FormatLogger` trait.
|
|
|
`to_string` applied to a type that implements `Display` in `println!` args:
backpack/lib/src/log.rs#L712
warning: `to_string` applied to a type that implements `Display` in `println!` args
--> backpack/lib/src/log.rs:712:36
|
712 | _ => println!("{}", obj.to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `eprintln!` args:
backpack/lib/src/log.rs#L711
warning: `to_string` applied to a type that implements `Display` in `eprintln!` args
--> backpack/lib/src/log.rs:711:43
|
711 | "error" => eprintln!("{}", obj.to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#to_string_in_format_args
= note: `-W clippy::to-string-in-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::to_string_in_format_args)]`
|
|
unused `self` argument:
backpack/lib/src/log.rs#L701
warning: unused `self` argument
--> backpack/lib/src/log.rs:701:18
|
701 | fn emit_json(&self, level: &str, message: &str) {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unused_self
= note: `-W clippy::unused-self` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_self)]`
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L690
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:690:51
|
690 | /// - Builds a structured JSON object using serde_json
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
690 - /// - Builds a structured JSON object using serde_json
690 + /// - Builds a structured JSON object using `serde_json`
|
|
|
temporary with significant `Drop` can be early dropped:
backpack/lib/src/github/tests.rs#L271
warning: temporary with significant `Drop` can be early dropped
--> backpack/lib/src/github/tests.rs:271:13
|
270 | async fn test_rerun_workflow_failure() {
| ________________________________________-
271 | | let mut server = setup_mock_server().await;
| | ^^^^^^
272 | |
273 | | let _mock = server
... |
288 | | }
| |_- temporary `server` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
271 ~
272 + let _mock = setup_mock_server().await.;
273 |
274 ~
|
|
|
temporary with significant `Drop` can be early dropped:
backpack/lib/src/github/tests.rs#L251
warning: temporary with significant `Drop` can be early dropped
--> backpack/lib/src/github/tests.rs:251:13
|
250 | async fn test_rerun_workflow_success() {
| ________________________________________-
251 | | let mut server = setup_mock_server().await;
| | ^^^^^^
252 | |
253 | | let _mock = server
... |
267 | | }
| |_- temporary `server` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
251 ~
252 + let _mock = setup_mock_server().await.;
253 |
254 ~
|
|
|
temporary with significant `Drop` can be early dropped:
backpack/lib/src/github/tests.rs#L233
warning: temporary with significant `Drop` can be early dropped
--> backpack/lib/src/github/tests.rs:233:13
|
232 | async fn test_get_workflow_runs_api_error() {
| _____________________________________________-
233 | | let mut server = setup_mock_server().await;
| | ^^^^^^
234 | |
235 | | let _mock = server
... |
247 | | }
| |_- temporary `server` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
233 ~
234 + let _mock = setup_mock_server().await.;
235 |
236 ~
|
|
|
temporary with significant `Drop` can be early dropped:
backpack/lib/src/github/tests.rs#L211
warning: temporary with significant `Drop` can be early dropped
--> backpack/lib/src/github/tests.rs:211:13
|
210 | async fn test_get_workflow_runs_empty_response() {
| __________________________________________________-
211 | | let mut server = setup_mock_server().await;
| | ^^^^^^
212 | |
213 | | let _mock = server
... |
229 | | }
| |_- temporary `server` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
211 ~
212 + let _mock = setup_mock_server().await.;
213 |
214 ~
|
|
|
temporary with significant `Drop` can be early dropped:
backpack/lib/src/github/tests.rs#L174
warning: temporary with significant `Drop` can be early dropped
--> backpack/lib/src/github/tests.rs:174:13
|
173 | async fn test_get_workflow_runs_success() {
| ___________________________________________-
174 | | let mut server = setup_mock_server().await;
| | ^^^^^^
175 | |
176 | | let _mock = server
... |
207 | | }
| |_- temporary `server` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
174 ~
175 + let _mock = setup_mock_server().await.;
176 |
177 ~
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/tests.rs#L134
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/tests.rs:134:32
|
134 | .header(AUTHORIZATION, format!("Bearer {}", TOKEN))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
134 - .header(AUTHORIZATION, format!("Bearer {}", TOKEN))
134 + .header(AUTHORIZATION, format!("Bearer {TOKEN}"))
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/tests.rs#L105
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/tests.rs:105:13
|
105 | format!("/repos/{}/pulls/{}/merge", REPO, pr_number).as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
105 - format!("/repos/{}/pulls/{}/merge", REPO, pr_number).as_str(),
105 + format!("/repos/{REPO}/pulls/{pr_number}/merge").as_str(),
|
|
|
temporary with significant `Drop` can be early dropped:
backpack/lib/src/github/tests.rs#L97
warning: temporary with significant `Drop` can be early dropped
--> backpack/lib/src/github/tests.rs:97:13
|
95 | fn test_attempt_merge_success() -> Result<()> {
| _______________________________________________-
96 | | // 1. Setup Mock Server
97 | | let mut server = mockito::Server::new();
| | ^^^^^^
98 | | let pr_number = 456;
... |
147 | | Ok(())
148 | | }
| |_- temporary `server` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#significant_drop_tightening
help: drop the temporary after the end of its last usage
|
122 ~ let mock_base = server.url();
123 + drop(server);
|
|
|
this could be a `const fn`:
backpack/lib/src/log.rs#L462
warning: this could be a `const fn`
--> backpack/lib/src/log.rs:462:5
|
462 | / pub fn new(inner: L, format: LogFormat) -> Self {
463 | | Self {
464 | | inner,
465 | | tasks: RefCell::new(Vec::new()),
... |
469 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_const_for_fn
= note: `-W clippy::missing-const-for-fn` implied by `-W clippy::nursery`
= help: to override `-W clippy::nursery` add `#[allow(clippy::missing_const_for_fn)]`
help: make the function `const`
|
462 | pub const fn new(inner: L, format: LogFormat) -> Self {
| +++++
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L448
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:448:47
|
448 | /// Stack of active step spans created by step()
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
448 - /// Stack of active step spans created by step()
448 + /// Stack of active step spans created by `step()`
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L445
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:445:47
|
445 | /// Stack of active task spans created by intro()
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
445 - /// Stack of active task spans created by intro()
445 + /// Stack of active task spans created by `intro()`
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L442
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:442:49
|
442 | /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
442 - /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
442 + /// The underlying formatter (SimpleLogger, `ModernLogger`, etc.)
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L442
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:442:35
|
442 | /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
442 - /// The underlying formatter (SimpleLogger, ModernLogger, etc.)
442 + /// The underlying formatter (`SimpleLogger`, ModernLogger, etc.)
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L437
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:437:51
|
437 | /// - Nested task spans via intro() / outro() / done()
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
437 - /// - Nested task spans via intro() / outro() / done()
437 + /// - Nested task spans via intro() / outro() / `done()`
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L437
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:437:41
|
437 | /// - Nested task spans via intro() / outro() / done()
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
437 - /// - Nested task spans via intro() / outro() / done()
437 + /// - Nested task spans via intro() / `outro()` / done()
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L437
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:437:31
|
437 | /// - Nested task spans via intro() / outro() / done()
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
437 - /// - Nested task spans via intro() / outro() / done()
437 + /// - Nested task spans via `intro()` / outro() / done()
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L380
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:380:44
|
380 | /// All quiet-mode logic is handled in the FormatLogger layer.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
380 - /// All quiet-mode logic is handled in the FormatLogger layer.
380 + /// All quiet-mode logic is handled in the `FormatLogger` layer.
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/tests.rs#L65
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/tests.rs:65:32
|
65 | .header(AUTHORIZATION, format!("Bearer {}", TOKEN))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
65 - .header(AUTHORIZATION, format!("Bearer {}", TOKEN))
65 + .header(AUTHORIZATION, format!("Bearer {TOKEN}"))
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/tests.rs#L61
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/tests.rs:61:15
|
61 | let url = format!("{}/repos/{}/pulls?state=open&per_page=100", mock_base, REPO);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
61 - let url = format!("{}/repos/{}/pulls?state=open&per_page=100", mock_base, REPO);
61 + let url = format!("{mock_base}/repos/{REPO}/pulls?state=open&per_page=100");
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L353
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:353:13
|
353 | format!("\x1b[36m⠿\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
353 - format!("\x1b[36m⠿\x1b[0m {}", m)
353 + format!("\x1b[36m⠿\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L351
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:351:13
|
351 | format!("* {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
351 - format!("* {}", m)
351 + format!("* {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/tests.rs#L51
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/tests.rs:51:22
|
51 | .mock("GET", format!("/repos/{}/pulls", REPO).as_str())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
51 - .mock("GET", format!("/repos/{}/pulls", REPO).as_str())
51 + .mock("GET", format!("/repos/{REPO}/pulls").as_str())
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/tests.rs#L40
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/tests.rs:40:16
|
40 | let body = format!(
| ________________^
41 | | r#"
42 | | [
43 | | {{ "number": 1, "title": "Dependabot PR", "user": {{ "login": "{}" }} }},
... |
47 | | DEPENDABOT_USER, DEPENDABOT_USER
48 | | );
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L345
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:345:9
|
345 | format!("✓ Done! {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
345 - format!("✓ Done! {}", m)
345 + format!("✓ Done! {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L340
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:340:9
|
340 | format!("✓ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
340 - format!("✓ {}", m)
340 + format!("✓ {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L335
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:335:9
|
335 | format!("→ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
335 - format!("→ {}", m)
335 + format!("→ {m}")
|
|
|
temporary with significant `Drop` can be early dropped:
backpack/lib/src/github/tests.rs#L37
warning: temporary with significant `Drop` can be early dropped
--> backpack/lib/src/github/tests.rs:37:13
|
35 | fn test_list_dependabot_prs_success() -> Result<()> {
| _____________________________________________________-
36 | | // 1. Setup Mock Server
37 | | let mut server = mockito::Server::new();
| | ^^^^^^
38 | | let mock_base = server.url();
... |
91 | | Ok(())
92 | | }
| |_- temporary `server` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#significant_drop_tightening
= note: `-W clippy::significant-drop-tightening` implied by `-W clippy::nursery`
= help: to override `-W clippy::nursery` add `#[allow(clippy::significant_drop_tightening)]`
help: drop the temporary after the end of its last usage
|
56 ~ .create();
57 + drop(server);
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L329
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:329:13
|
329 | format!("\x1b[90m {}\x1b[0m", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
329 - format!("\x1b[90m {}\x1b[0m", m)
329 + format!("\x1b[90m {m}\x1b[0m")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L327
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:327:13
|
327 | format!(" {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
327 - format!(" {}", m)
327 + format!(" {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L321
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:321:9
|
321 | format!(" {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
321 - format!(" {}", m)
321 + format!(" {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L315
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:315:13
|
315 | format!("\x1b[31m✗\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
315 - format!("\x1b[31m✗\x1b[0m {}", m)
315 + format!("\x1b[31m✗\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L313
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:313:13
|
313 | format!("X {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
313 - format!("X {}", m)
313 + format!("X {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L306
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:306:13
|
306 | format!("\x1b[33m⚠\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
306 - format!("\x1b[33m⚠\x1b[0m {}", m)
306 + format!("\x1b[33m⚠\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L304
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:304:13
|
304 | format!("! {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
304 - format!("! {}", m)
304 + format!("! {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L297
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:297:13
|
297 | format!("\x1b[32m✔\x1b[0m {}", m)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
297 - format!("\x1b[32m✔\x1b[0m {}", m)
297 + format!("\x1b[32m✔\x1b[0m {m}")
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/log.rs#L295
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/log.rs:295:13
|
295 | format!("+ {}", m)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
295 - format!("+ {}", m)
295 + format!("+ {m}")
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L285
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:285:46
|
285 | /// Quiet-mode suppression is handled by the FormatLogger trait.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
285 - /// Quiet-mode suppression is handled by the FormatLogger trait.
285 + /// Quiet-mode suppression is handled by the `FormatLogger` trait.
|
|
|
doc list item overindented:
backpack/lib/src/log.rs#L123
warning: doc list item overindented
--> backpack/lib/src/log.rs:123:5
|
123 | /// • wrap the raw formatting
| ^^^^^^^^ help: try using ` ` (4 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_overindented_list_items
|
|
doc list item overindented:
backpack/lib/src/log.rs#L122
warning: doc list item overindented
--> backpack/lib/src/log.rs:122:5
|
122 | /// • automatically apply quiet-mode suppression
| ^^^^^^^^ help: try using ` ` (4 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_overindented_list_items
= note: `-W clippy::doc-overindented-list-items` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::doc_overindented_list_items)]`
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L111
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:111:43
|
111 | /// how long the task took when outro() / done() is called.
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
help: try
|
111 - /// how long the task took when outro() / done() is called.
111 + /// how long the task took when outro() / `done()` is called.
|
|
|
item in documentation is missing backticks:
backpack/lib/src/log.rs#L111
warning: item in documentation is missing backticks
--> backpack/lib/src/log.rs:111:33
|
111 | /// how long the task took when outro() / done() is called.
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_markdown
= note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]`
help: try
|
111 - /// how long the task took when outro() / done() is called.
111 + /// how long the task took when `outro()` / done() is called.
|
|
|
`format!` in `eprintln!` args:
backpack/lib/src/github/mod.rs#L44
warning: `format!` in `eprintln!` args
--> backpack/lib/src/github/mod.rs:44:17
|
44 | / eprintln!(
45 | | "{}",
46 | | format!("{}", "Error: GITHUB_TOKEN environment variable not set. Please set it to your Personal Access Token.".red())
47 | | );
| |_________________^
|
= help: combine the `format!(..)` arguments with the outer `eprintln!(..)` call
= help: or consider changing `format!` to `format_args!`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#format_in_format_args
= note: `-W clippy::format-in-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::format_in_format_args)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/mod.rs#L41
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/mod.rs:41:5
|
41 | pub fn new() -> Result<Self, Box<dyn std::error::Error>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/log.rs#L36
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/log.rs:36:1
|
36 | pub fn init() {
| ^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/log.rs:73:41
|
73 | && ["debug", "trace"].contains(&std::env::var("RUST_LOG").unwrap().to_lowercase().as_str())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/log.rs#L32
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/log.rs:32:1
|
32 | pub fn log() -> &'static Arc<dyn ScreenLogger + Send + Sync> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/log.rs:33:5
|
33 | LOGGER.get().expect("Logger not initialized")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
`format!` in `eprintln!` args:
backpack/lib/src/github/mod.rs#L44
warning: `format!` in `eprintln!` args
--> backpack/lib/src/github/mod.rs:44:17
|
44 | / eprintln!(
45 | | "{}",
46 | | format!("{}", "Error: GITHUB_TOKEN environment variable not set. Please set it to your Personal Access Token.".red())
47 | | );
| |_________________^
|
= help: combine the `format!(..)` arguments with the outer `eprintln!(..)` call
= help: or consider changing `format!` to `format_args!`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#format_in_format_args
= note: `-W clippy::format-in-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::format_in_format_args)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/mod.rs#L41
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/mod.rs:41:5
|
41 | pub fn new() -> Result<Self, Box<dyn std::error::Error>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/github/workflow.rs#L195
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/github/workflow.rs:195:1
|
195 | pub fn delete_failed_workflows(client: &GitHubClient, repo: &str) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/github/workflow.rs:228:39
|
228 | ... let url = api_base_clone.join(&delete_path).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/workflow.rs#L186
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/workflow.rs:186:35
|
186 | Err(e) => log().fail(&format!("Failed: {}", e)),
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
186 - Err(e) => log().fail(&format!("Failed: {}", e)),
186 + Err(e) => log().fail(&format!("Failed: {e}")),
|
|
|
matching over `()` is more explicit:
backpack/lib/src/github/workflow.rs#L185
warning: matching over `()` is more explicit
--> backpack/lib/src/github/workflow.rs:185:16
|
185 | Ok(_) => log().success(""),
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ignored_unit_patterns
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/github/workflow.rs#L195
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/github/workflow.rs:195:1
|
195 | pub fn delete_failed_workflows(client: &GitHubClient, repo: &str) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/github/workflow.rs:228:39
|
228 | ... let url = api_base_clone.join(&delete_path).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
matching over `()` is more explicit:
backpack/lib/src/github/workflow.rs#L185
warning: matching over `()` is more explicit
--> backpack/lib/src/github/workflow.rs:185:16
|
185 | Ok(_) => log().success(""),
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ignored_unit_patterns
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/github/workflow.rs#L184
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/github/workflow.rs:184:30
|
184 | match rerun_workflow(&client, &repo, run.id).await {
| ^^^^^^^ help: change this to: `client`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/workflow.rs#L116
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/workflow.rs:116:1
|
116 | / pub async fn rerun_workflows(
117 | | client: &GitHubClient,
118 | | commit: Option<String>,
119 | | repo: Option<String>,
120 | | ) -> Result<(), Box<dyn Error>> {
| |_______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/workflow.rs#L94
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/workflow.rs:94:15
|
94 | let url = format!(
| _______________^
95 | | "https://api.github.com/repos/{}/actions/runs/{}/rerun-failed-jobs",
96 | | repo, run_id
97 | | );
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/github/workflow.rs#L145
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/github/workflow.rs:145:34
|
145 | let runs = get_workflow_runs(&client, &repo, &commit).await?;
| ^^^^^^^ help: change this to: `client`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/workflow.rs#L141
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/workflow.rs:141:5
|
141 | println!("Repository: {}\n", repo);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
141 - println!("Repository: {}\n", repo);
141 + println!("Repository: {repo}\n");
|
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
backpack/lib/src/github/workflow.rs#L133
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> backpack/lib/src/github/workflow.rs:133:16
|
133 | let repo = match repo {
| ________________^
134 | | Some(r) => r,
135 | | None => {
136 | | println!("No repository specified, detecting from git remote...");
... |
139 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else
help: try
|
133 ~ let repo = if let Some(r) = repo { r } else {
134 + println!("No repository specified, detecting from git remote...");
135 + get_repo_from_git()?
136 ~ };
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/workflow.rs#L130
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/workflow.rs:130:5
|
130 | println!("Using commit: {}", commit);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
130 - println!("Using commit: {}", commit);
130 + println!("Using commit: {commit}");
|
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
backpack/lib/src/github/workflow.rs#L122
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> backpack/lib/src/github/workflow.rs:122:18
|
122 | let commit = match commit {
| __________________^
123 | | Some(c) => c,
124 | | None => {
125 | | println!("No commit specified, using latest commit...");
... |
128 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else
help: try
|
122 ~ let commit = if let Some(c) = commit { c } else {
123 + println!("No commit specified, using latest commit...");
124 + get_latest_commit()?
125 ~ };
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/workflow.rs#L66
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/workflow.rs:66:15
|
66 | let url = format!(
| _______________^
67 | | "https://api.github.com/repos/{}/actions/runs?head_sha={}",
68 | | repo, commit
69 | | );
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/workflow.rs#L116
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/workflow.rs:116:1
|
116 | / pub async fn rerun_workflows(
117 | | client: &GitHubClient,
118 | | commit: Option<String>,
119 | | repo: Option<String>,
120 | | ) -> Result<(), Box<dyn Error>> {
| |_______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/github/workflow.rs#L94
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/github/workflow.rs:94:15
|
94 | let url = format!(
| _______________^
95 | | "https://api.github.com/repos/{}/actions/runs/{}/rerun-failed-jobs",
96 | | repo, run_id
97 | | );
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/release.rs#L265
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/release.rs:265:1
|
265 | pub fn create_release(client: &GitHubClient, repo: &str) -> Result<(), reqwest::Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
usage of wildcard import:
backpack/lib/src/github/workflow.rs#L6
warning: usage of wildcard import
--> backpack/lib/src/github/workflow.rs:6:5
|
6 | use crate::log::*;
| ^^^^^^^^^^^^^ help: try: `crate::log::{ScreenLogger, log, FormatLogger}`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#wildcard_imports
= note: `-W clippy::wildcard-imports` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::wildcard_imports)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/release.rs#L265
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/release.rs:265:1
|
265 | pub fn create_release(client: &GitHubClient, repo: &str) -> Result<(), reqwest::Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/release.rs#L132
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/release.rs:132:1
|
132 | / pub fn delete_all_releases(
133 | | client: &GitHubClient,
134 | | repo: &str,
135 | | ) -> Result<(), Box<dyn std::error::Error>> {
| |___________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/github/release.rs#L132
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/github/release.rs:132:1
|
132 | / pub fn delete_all_releases(
133 | | client: &GitHubClient,
134 | | repo: &str,
135 | | ) -> Result<(), Box<dyn std::error::Error>> {
| |___________________________________________^
|
note: first possible panic found here
--> backpack/lib/src/github/release.rs:152:31
|
152 | let url = api_base_clone.join(&delete_path).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/release.rs#L132
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/release.rs:132:1
|
132 | / pub fn delete_all_releases(
133 | | client: &GitHubClient,
134 | | repo: &str,
135 | | ) -> Result<(), Box<dyn std::error::Error>> {
| |___________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/github/release.rs#L132
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/github/release.rs:132:1
|
132 | / pub fn delete_all_releases(
133 | | client: &GitHubClient,
134 | | repo: &str,
135 | | ) -> Result<(), Box<dyn std::error::Error>> {
| |___________________________________________^
|
note: first possible panic found here
--> backpack/lib/src/github/release.rs:152:31
|
152 | let url = api_base_clone.join(&delete_path).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/github/release.rs#L42
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/github/release.rs:42:1
|
42 | pub fn delete_old_container_versions(client: &GitHubClient, repo: &str) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/github/release.rs:84:35
|
84 | let url = api_base_clone.join(&delete_path).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
= note: `-W clippy::missing-panics-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_panics_doc)]`
|
|
docs for function which may panic missing `# Panics` section:
backpack/lib/src/github/release.rs#L42
warning: docs for function which may panic missing `# Panics` section
--> backpack/lib/src/github/release.rs:42:1
|
42 | pub fn delete_old_container_versions(client: &GitHubClient, repo: &str) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> backpack/lib/src/github/release.rs:84:35
|
84 | let url = api_base_clone.join(&delete_path).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_panics_doc
= note: `-W clippy::missing-panics-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_panics_doc)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L130
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:130:1
|
130 | / pub fn update_pr_branch(
131 | | client: &Client,
132 | | repo: &str,
133 | | token: &str,
134 | | pr: &PullRequest,
135 | | ) -> Result<bool> {
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L102
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:102:1
|
102 | / pub fn attempt_merge(
103 | | client: &Client,
104 | | repo: &str,
105 | | token: &str,
106 | | pr: &PullRequest,
107 | | ) -> Result<Response> {
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L130
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:130:1
|
130 | / pub fn update_pr_branch(
131 | | client: &Client,
132 | | repo: &str,
133 | | token: &str,
134 | | pr: &PullRequest,
135 | | ) -> Result<bool> {
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L55
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:55:1
|
55 | pub fn process_pr(client: &Client, repo: &str, token: &str, pr: &PullRequest) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L102
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:102:1
|
102 | / pub fn attempt_merge(
103 | | client: &Client,
104 | | repo: &str,
105 | | token: &str,
106 | | pr: &PullRequest,
107 | | ) -> Result<Response> {
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L22
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:22:1
|
22 | pub fn list_dependabot_prs(client: &Client, repo: &str, token: &str) -> Result<Vec<PullRequest>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L55
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:55:1
|
55 | pub fn process_pr(client: &Client, repo: &str, token: &str, pr: &PullRequest) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/github/pr.rs#L22
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/github/pr.rs:22:1
|
22 | pub fn list_dependabot_prs(client: &Client, repo: &str, token: &str) -> Result<Vec<PullRequest>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L214
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:214:13
|
214 | eprintln!("Error managing branches: {}", e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
214 - eprintln!("Error managing branches: {}", e);
214 + eprintln!("Error managing branches: {e}");
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L214
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:214:13
|
214 | eprintln!("Error managing branches: {}", e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
214 - eprintln!("Error managing branches: {}", e);
214 + eprintln!("Error managing branches: {e}");
|
|
|
matching over `()` is more explicit:
backpack/lib/src/git/mod.rs#L212
warning: matching over `()` is more explicit
--> backpack/lib/src/git/mod.rs:212:12
|
212 | Ok(_) => cliclack::outro("You're all set!")?,
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ignored_unit_patterns
= note: `-W clippy::ignored-unit-patterns` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::ignored_unit_patterns)]`
|
|
unnecessary semicolon:
backpack/lib/src/git/mod.rs#L217
warning: unnecessary semicolon
--> backpack/lib/src/git/mod.rs:217:6
|
217 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_semicolon
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/git/mod.rs#L208
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/git/mod.rs:208:1
|
208 | pub fn prune(confirm: bool) -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L201
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:201:31
|
201 | cliclack::log::remark(format!("\x1b[32m✔\x1b[0m Deleting branch '{}'.", name))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
201 - cliclack::log::remark(format!("\x1b[32m✔\x1b[0m Deleting branch '{}'.", name))?;
201 + cliclack::log::remark(format!("\x1b[32m✔\x1b[0m Deleting branch '{name}'."))?;
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L191
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:191:34
|
191 | false => println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
191 - false => println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name),
191 + false => println!("\x1b[90m - Skipping '{branch_name}'.\x1b[0m"),
|
|
|
`match` on a boolean expression:
backpack/lib/src/git/mod.rs#L189
warning: `match` on a boolean expression
--> backpack/lib/src/git/mod.rs:189:21
|
189 | / match confirm {
190 | | true => branches_to_delete.push(branch_name),
191 | | false => println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name),
192 | | };
| |_____________________^ help: consider using an `if`/`else` expression: `if confirm { branches_to_delete.push(branch_name) } else { println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name) }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#match_bool
|
|
unnecessary semicolon:
backpack/lib/src/git/mod.rs#L192
warning: unnecessary semicolon
--> backpack/lib/src/git/mod.rs:192:22
|
192 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_semicolon
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L183
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:183:56
|
183 | false => cliclack::log::remark(format!(
| ________________________________________________________^
184 | | "\x1b[90m - Skipping '{}'.\x1b[0m",
185 | | branch_name
186 | | ))?,
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
`match` on a boolean expression:
backpack/lib/src/git/mod.rs#L181
warning: `match` on a boolean expression
--> backpack/lib/src/git/mod.rs:181:21
|
181 | / match ans {
182 | | true => branches_to_delete.push(branch_name),
183 | | false => cliclack::log::remark(format!(
184 | | "\x1b[90m - Skipping '{}'.\x1b[0m",
185 | | branch_name
186 | | ))?,
187 | | };
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#match_bool
help: consider using an `if`/`else` expression
|
181 ~ if ans { branches_to_delete.push(branch_name) } else { cliclack::log::remark(format!(
182 + "\x1b[90m - Skipping '{}'.\x1b[0m",
183 + branch_name
184 ~ ))? };
|
|
|
matching over `()` is more explicit:
backpack/lib/src/git/mod.rs#L212
warning: matching over `()` is more explicit
--> backpack/lib/src/git/mod.rs:212:12
|
212 | Ok(_) => cliclack::outro("You're all set!")?,
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ignored_unit_patterns
= note: `-W clippy::ignored-unit-patterns` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::ignored_unit_patterns)]`
|
|
unnecessary semicolon:
backpack/lib/src/git/mod.rs#L217
warning: unnecessary semicolon
--> backpack/lib/src/git/mod.rs:217:6
|
217 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_semicolon
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/git/mod.rs#L208
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/git/mod.rs:208:1
|
208 | pub fn prune(confirm: bool) -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L201
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:201:31
|
201 | cliclack::log::remark(format!("\x1b[32m✔\x1b[0m Deleting branch '{}'.", name))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
201 - cliclack::log::remark(format!("\x1b[32m✔\x1b[0m Deleting branch '{}'.", name))?;
201 + cliclack::log::remark(format!("\x1b[32m✔\x1b[0m Deleting branch '{name}'."))?;
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L191
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:191:34
|
191 | false => println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
191 - false => println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name),
191 + false => println!("\x1b[90m - Skipping '{branch_name}'.\x1b[0m"),
|
|
|
`match` on a boolean expression:
backpack/lib/src/git/mod.rs#L189
warning: `match` on a boolean expression
--> backpack/lib/src/git/mod.rs:189:21
|
189 | / match confirm {
190 | | true => branches_to_delete.push(branch_name),
191 | | false => println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name),
192 | | };
| |_____________________^ help: consider using an `if`/`else` expression: `if confirm { branches_to_delete.push(branch_name) } else { println!("\x1b[90m - Skipping '{}'.\x1b[0m", branch_name) }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#match_bool
|
|
unnecessary semicolon:
backpack/lib/src/git/mod.rs#L192
warning: unnecessary semicolon
--> backpack/lib/src/git/mod.rs:192:22
|
192 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_semicolon
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L183
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:183:56
|
183 | false => cliclack::log::remark(format!(
| ________________________________________________________^
184 | | "\x1b[90m - Skipping '{}'.\x1b[0m",
185 | | branch_name
186 | | ))?,
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
`match` on a boolean expression:
backpack/lib/src/git/mod.rs#L181
warning: `match` on a boolean expression
--> backpack/lib/src/git/mod.rs:181:21
|
181 | / match ans {
182 | | true => branches_to_delete.push(branch_name),
183 | | false => cliclack::log::remark(format!(
184 | | "\x1b[90m - Skipping '{}'.\x1b[0m",
185 | | branch_name
186 | | ))?,
187 | | };
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#match_bool
help: consider using an `if`/`else` expression
|
181 ~ if ans { branches_to_delete.push(branch_name) } else { cliclack::log::remark(format!(
182 + "\x1b[90m - Skipping '{}'.\x1b[0m",
183 + branch_name
184 ~ ))? };
|
|
|
unnecessary semicolon:
backpack/lib/src/git/mod.rs#L187
warning: unnecessary semicolon
--> backpack/lib/src/git/mod.rs:187:22
|
187 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_semicolon
= note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]`
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L172
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:172:47
|
172 | ... cliclack::confirm(format!(
| _________________________________________^
173 | | ... "Branch '{}' has no remote counterpart. Delete locally?",
174 | | ... branch_name
175 | | ... ))
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
`match` on a boolean expression:
backpack/lib/src/git/mod.rs#L169
warning: `match` on a boolean expression
--> backpack/lib/src/git/mod.rs:169:31
|
169 | let ans = match confirm {
| _______________________________^
170 | | true => true,
171 | | false => {
172 | | cliclack::confirm(format!(
... |
179 | | };
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#match_bool
= note: `-W clippy::match-bool` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::match_bool)]`
help: consider using an `if`/`else` expression
|
169 ~ let ans = if confirm { true } else {
170 + cliclack::confirm(format!(
171 + "Branch '{}' has no remote counterpart. Delete locally?",
172 + branch_name
173 + ))
174 + .initial_value(false) // Default to 'No'
175 + .interact()?
176 ~ };
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L159
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:159:17
|
159 | / println!(
160 | | " - Branch '{}' tracks a deleted remote branch. Deleting...",
161 | | branch_name
162 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
unnecessary semicolon:
backpack/lib/src/git/mod.rs#L187
warning: unnecessary semicolon
--> backpack/lib/src/git/mod.rs:187:22
|
187 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_semicolon
= note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]`
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L172
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:172:47
|
172 | ... cliclack::confirm(format!(
| _________________________________________^
173 | | ... "Branch '{}' has no remote counterpart. Delete locally?",
174 | | ... branch_name
175 | | ... ))
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
`match` on a boolean expression:
backpack/lib/src/git/mod.rs#L169
warning: `match` on a boolean expression
--> backpack/lib/src/git/mod.rs:169:31
|
169 | let ans = match confirm {
| _______________________________^
170 | | true => true,
171 | | false => {
172 | | cliclack::confirm(format!(
... |
179 | | };
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#match_bool
= note: `-W clippy::match-bool` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::match_bool)]`
help: consider using an `if`/`else` expression
|
169 ~ let ans = if confirm { true } else {
170 + cliclack::confirm(format!(
171 + "Branch '{}' has no remote counterpart. Delete locally?",
172 + branch_name
173 + ))
174 + .initial_value(false) // Default to 'No'
175 + .interact()?
176 ~ };
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L159
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:159:17
|
159 | / println!(
160 | | " - Branch '{}' tracks a deleted remote branch. Deleting...",
161 | | branch_name
162 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L103
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:103:17
|
103 | run(&mut Command::new("git").args(["push", "-f"]))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["push", "-f"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L96
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:96:13
|
96 | run(&mut Command::new("git").args(["commit", "--all", "--amend", "--no-edit"]))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["commit", "--all", "--amend", "--no-edit"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:91:13
|
91 | run(&mut Command::new("git").args(["reset", "--soft", &head_arg]))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["reset", "--soft", &head_arg])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L82
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:82:22
|
82 | let status = run(&mut Command::new("git").args(["commit", "-am", "wip 🚧: work-in-progress"]))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["commit", "-am", "wip 🚧: work-in-progress"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L79
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:79:22
|
79 | let status = run(&mut Command::new("git").args(["add", "--all"]))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["add", "--all"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L75
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:75:13
|
75 | run(&mut Command::new("git").args(["--no-pager", "diff"]))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["--no-pager", "diff"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L103
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:103:17
|
103 | run(&mut Command::new("git").args(["push", "-f"]))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["push", "-f"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L96
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:96:13
|
96 | run(&mut Command::new("git").args(["commit", "--all", "--amend", "--no-edit"]))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["commit", "--all", "--amend", "--no-edit"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:91:13
|
91 | run(&mut Command::new("git").args(["reset", "--soft", &head_arg]))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["reset", "--soft", &head_arg])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L82
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:82:22
|
82 | let status = run(&mut Command::new("git").args(["commit", "-am", "wip 🚧: work-in-progress"]))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["commit", "-am", "wip 🚧: work-in-progress"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L79
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:79:22
|
79 | let status = run(&mut Command::new("git").args(["add", "--all"]))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["add", "--all"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
backpack/lib/src/git/mod.rs#L75
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> backpack/lib/src/git/mod.rs:75:13
|
75 | run(&mut Command::new("git").args(["--no-pager", "diff"]))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Command::new("git").args(["--no-pager", "diff"])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/git/mod.rs#L16
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/git/mod.rs:16:1
|
16 | pub fn wip(no_push: bool, no_diff: bool, rewind: Option<u32>) -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/git/mod.rs#L16
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/git/mod.rs:16:1
|
16 | pub fn wip(no_push: bool, no_diff: bool, rewind: Option<u32>) -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L11
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:11:9
|
11 | anyhow::bail!("{}", msg);
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
11 - anyhow::bail!("{}", msg);
11 + anyhow::bail!("{msg}");
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/git/mod.rs#L11
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/git/mod.rs:11:9
|
11 | anyhow::bail!("{}", msg);
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
11 - anyhow::bail!("{}", msg);
11 + anyhow::bail!("{msg}");
|
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/ghk/mod.rs#L11
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/ghk/mod.rs:11:1
|
11 | pub fn main(cli: Args) -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/ghk/mod.rs#L11
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/ghk/mod.rs:11:1
|
11 | pub fn main(cli: Args) -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
this looks like a formatting argument but it is not part of a formatting macro:
backpack/lib/src/ghk/git.rs#L254
warning: this looks like a formatting argument but it is not part of a formatting macro
--> backpack/lib/src/ghk/git.rs:254:40
|
254 | .template("{spinner:.cyan} {msg}")
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#literal_string_with_formatting_args
= note: `-W clippy::literal-string-with-formatting-args` implied by `-W clippy::nursery`
= help: to override `-W clippy::nursery` add `#[allow(clippy::literal_string_with_formatting_args)]`
|
|
this looks like a formatting argument but it is not part of a formatting macro:
backpack/lib/src/ghk/git.rs#L254
warning: this looks like a formatting argument but it is not part of a formatting macro
--> backpack/lib/src/ghk/git.rs:254:40
|
254 | .template("{spinner:.cyan} {msg}")
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#literal_string_with_formatting_args
= note: `-W clippy::literal-string-with-formatting-args` implied by `-W clippy::nursery`
= help: to override `-W clippy::nursery` add `#[allow(clippy::literal_string_with_formatting_args)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/ghk/config.rs#L59
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/ghk/config.rs:59:5
|
59 | pub fn set(&mut self, key: &str, value: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/ghk/config.rs#L59
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/ghk/config.rs:59:5
|
59 | pub fn set(&mut self, key: &str, value: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/ghk/config.rs#L37
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/ghk/config.rs:37:5
|
37 | pub fn save(&self) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
= note: `-W clippy::missing-errors-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_errors_doc)]`
|
|
docs for function returning `Result` missing `# Errors` section:
backpack/lib/src/ghk/config.rs#L37
warning: docs for function returning `Result` missing `# Errors` section
--> backpack/lib/src/ghk/config.rs:37:5
|
37 | pub fn save(&self) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_errors_doc
= note: `-W clippy::missing-errors-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_errors_doc)]`
|
|
this function's return value is unnecessary:
backpack/lib/src/ghk/commands/status.rs#L4
warning: this function's return value is unnecessary
--> backpack/lib/src/ghk/commands/status.rs:4:1
|
4 | pub fn run() -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
help: remove the return type...
|
4 - pub fn run() -> Result<()> {
4 + pub fn run() -> () {
|
help: ...and then remove returned values
|
61- Ok(())
|
|
|
this function's return value is unnecessary:
backpack/lib/src/ghk/commands/status.rs#L4
warning: this function's return value is unnecessary
--> backpack/lib/src/ghk/commands/status.rs:4:1
|
4 | pub fn run() -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
help: remove the return type...
|
4 - pub fn run() -> Result<()> {
4 + pub fn run() -> () {
|
help: ...and then remove returned values
|
61- Ok(())
|
|
|
this function's return value is unnecessary:
backpack/lib/src/ghk/commands/setup.rs#L185
warning: this function's return value is unnecessary
--> backpack/lib/src/ghk/commands/setup.rs:185:1
|
185 | fn runpkg(cmd: &str, args: &[&str]) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
help: remove the return type...
|
185 - fn runpkg(cmd: &str, args: &[&str]) -> Result<()> {
185 + fn runpkg(cmd: &str, args: &[&str]) -> () {
|
help: ...and then remove returned values
|
193 ~ return ;
194 | }
...
200 | util::ok("Installed");
201 ~
202 | }
203 | Ok(_) => {
204 | util::warn("Install failed");
205 ~
206 | }
207 | Err(e) => {
208 | util::warn(&format!("Error: {e}"));
209 ~
|
|
|
this function's return value is unnecessary:
backpack/lib/src/ghk/commands/setup.rs#L185
warning: this function's return value is unnecessary
--> backpack/lib/src/ghk/commands/setup.rs:185:1
|
185 | fn runpkg(cmd: &str, args: &[&str]) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
help: remove the return type...
|
185 - fn runpkg(cmd: &str, args: &[&str]) -> Result<()> {
185 + fn runpkg(cmd: &str, args: &[&str]) -> () {
|
help: ...and then remove returned values
|
193 ~ return ;
194 | }
...
200 | util::ok("Installed");
201 ~
202 | }
203 | Ok(_) => {
204 | util::warn("Install failed");
205 ~
206 | }
207 | Err(e) => {
208 | util::warn(&format!("Error: {e}"));
209 ~
|
|
|
this function's return value is unnecessary:
backpack/lib/src/ghk/commands/setup.rs#L147
warning: this function's return value is unnecessary
--> backpack/lib/src/ghk/commands/setup.rs:147:1
|
147 | fn runsudo(args: &[&str]) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
= note: `-W clippy::unnecessary-wraps` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_wraps)]`
help: remove the return type...
|
147 - fn runsudo(args: &[&str]) -> Result<()> {
147 + fn runsudo(args: &[&str]) -> () {
|
help: ...and then remove returned values
|
152 ~ return ;
153 | }
...
171 | util::ok(&format!("{last} installed"));
172 ~
173 | }
174 | Ok(_) => {
175 | util::warn("Install failed - try running manually");
176 ~
177 | }
178 | Err(e) => {
179 | util::warn(&format!("Could not run command: {e}"));
180 ~
|
|
|
this function's return value is unnecessary:
backpack/lib/src/ghk/commands/setup.rs#L147
warning: this function's return value is unnecessary
--> backpack/lib/src/ghk/commands/setup.rs:147:1
|
147 | fn runsudo(args: &[&str]) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_wraps
= note: `-W clippy::unnecessary-wraps` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_wraps)]`
help: remove the return type...
|
147 - fn runsudo(args: &[&str]) -> Result<()> {
147 + fn runsudo(args: &[&str]) -> () {
|
help: ...and then remove returned values
|
152 ~ return ;
153 | }
...
171 | util::ok(&format!("{last} installed"));
172 ~
173 | }
174 | Ok(_) => {
175 | util::warn("Install failed - try running manually");
176 ~
177 | }
178 | Err(e) => {
179 | util::warn(&format!("Could not run command: {e}"));
180 ~
|
|
|
the borrowed expression implements the required traits:
backpack/lib/src/ghk/commands/setup.rs#L85
warning: the borrowed expression implements the required traits
--> backpack/lib/src/ghk/commands/setup.rs:85:22
|
85 | .with_prompt(&format!("Install {tool} now?"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Install {tool} now?")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
the borrowed expression implements the required traits:
backpack/lib/src/ghk/commands/setup.rs#L85
warning: the borrowed expression implements the required traits
--> backpack/lib/src/ghk/commands/setup.rs:85:22
|
85 | .with_prompt(&format!("Install {tool} now?"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Install {tool} now?")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/setup.rs#L38
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/setup.rs:38:19
|
38 | util::ok(&format!("Logged in as {}", user));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
38 - util::ok(&format!("Logged in as {}", user));
38 + util::ok(&format!("Logged in as {user}"));
|
|
|
this function has too many lines (103/100):
backpack/lib/src/ghk/commands/push.rs#L5
warning: this function has too many lines (103/100)
--> backpack/lib/src/ghk/commands/push.rs:5:1
|
5 | pub fn run() -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_lines
= note: `-W clippy::too-many-lines` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::too_many_lines)]`
|
|
this function has too many lines (103/100):
backpack/lib/src/ghk/commands/push.rs#L5
warning: this function has too many lines (103/100)
--> backpack/lib/src/ghk/commands/push.rs:5:1
|
5 | pub fn run() -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_lines
= note: `-W clippy::too-many-lines` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::too_many_lines)]`
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/logout.rs#L12
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/logout.rs:12:17
|
12 | util::info(&format!("Logging out from {}...", user));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
12 - util::info(&format!("Logging out from {}...", user));
12 + util::info(&format!("Logging out from {user}..."));
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/logout.rs#L12
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/logout.rs:12:17
|
12 | util::info(&format!("Logging out from {}...", user));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
12 - util::info(&format!("Logging out from {}...", user));
12 + util::info(&format!("Logging out from {user}..."));
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/login.rs#L17
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/login.rs:17:19
|
17 | util::ok(&format!("Connected as {}", user));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
17 - util::ok(&format!("Connected as {}", user));
17 + util::ok(&format!("Connected as {user}"));
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/login.rs#L17
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/login.rs:17:19
|
17 | util::ok(&format!("Connected as {}", user));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
17 - util::ok(&format!("Connected as {}", user));
17 + util::ok(&format!("Connected as {user}"));
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/login.rs#L7
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/login.rs:7:19
|
7 | util::ok(&format!("Already logged in as {}", user));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
7 - util::ok(&format!("Already logged in as {}", user));
7 + util::ok(&format!("Already logged in as {user}"));
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/login.rs#L7
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/login.rs:7:19
|
7 | util::ok(&format!("Already logged in as {}", user));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
help: change this to
|
7 - util::ok(&format!("Already logged in as {}", user));
7 + util::ok(&format!("Already logged in as {user}"));
|
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/license.rs#L71
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/license.rs:71:29
|
71 | LicenseKind::Gpl => format!(
| _____________________________^
72 | | "Copyright (C) {} {}\n\n\
73 | | This program is free software: you can redistribute it and/or modify\n\
74 | | it under the terms of the GNU General Public License as published by\n\
... |
83 | | year, author
84 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/license.rs#L71
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/license.rs:71:29
|
71 | LicenseKind::Gpl => format!(
| _____________________________^
72 | | "Copyright (C) {} {}\n\n\
73 | | This program is free software: you can redistribute it and/or modify\n\
74 | | it under the terms of the GNU General Public License as published by\n\
... |
83 | | year, author
84 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/license.rs#L58
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/license.rs:58:32
|
58 | LicenseKind::Apache => format!(
| ________________________________^
59 | | "Copyright {} {}\n\n\
60 | | Licensed under the Apache License, Version 2.0 (the \"License\");\n\
61 | | you may not use this file except in compliance with the License.\n\
... |
69 | | year, author
70 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::uninlined_format_args)]`
|
|
this argument is passed by value, but not consumed in the function body:
backpack/lib/src/ghk/commands/license.rs#L8
warning: this argument is passed by value, but not consumed in the function body
--> backpack/lib/src/ghk/commands/license.rs:8:18
|
8 | pub fn run(kind: Option<LicenseKind>) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
help: consider taking a reference instead
|
8 | pub fn run(kind: Option<&LicenseKind>) -> Result<()> {
| +
|
|
variables can be used directly in the `format!` string:
backpack/lib/src/ghk/commands/license.rs#L58
warning: variables can be used directly in the `format!` string
--> backpack/lib/src/ghk/commands/license.rs:58:32
|
58 | LicenseKind::Apache => format!(
| ________________________________^
59 | | "Copyright {} {}\n\n\
60 | | Licensed under the Apache License, Version 2.0 (the \"License\");\n\
61 | | you may not use this file except in compliance with the License.\n\
... |
69 | | year, author
70 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::uninlined_format_args)]`
|
|
this argument is passed by value, but not consumed in the function body:
backpack/lib/src/ghk/commands/license.rs#L8
warning: this argument is passed by value, but not consumed in the function body
--> backpack/lib/src/ghk/commands/license.rs:8:18
|
8 | pub fn run(kind: Option<LicenseKind>) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
help: consider taking a reference instead
|
8 | pub fn run(kind: Option<&LicenseKind>) -> Result<()> {
| +
|
|
adding items after statements is confusing, since items exist from the start of the scope:
backpack/lib/src/ghk/commands/ignore.rs#L52
warning: adding items after statements is confusing, since items exist from the start of the scope
--> backpack/lib/src/ghk/commands/ignore.rs:52:13
|
52 | use std::fmt::Write as _;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements
= note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
backpack/lib/src/ghk/commands/ignore.rs#L44
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> backpack/lib/src/ghk/commands/ignore.rs:44:5
|
44 | / match main {
45 | | Some(main_content) => {
46 | | let path = ".gitignore";
47 | | let existing = fs::read_to_string(path).unwrap_or_default();
... |
81 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else
= note: `-W clippy::single-match-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::single_match_else)]`
help: try
|
44 ~ if let Some(main_content) = main {
45 + let path = ".gitignore";
46 + let existing = fs::read_to_string(path).unwrap_or_default();
47 +
48 + // Build final template: main + all base templates
49 + let mut combined = format!("# {name}\n{main_content}");
50 +
51 + use std::fmt::Write as _;
52 + for (base_name, base_content) in BASE_TEMPLATES {
53 + let _ = write!(combined, "\n# base: {base_name}\n{base_content}");
54 + }
55 +
56 + // If .gitignore already contains the first line of the main template, skip
57 + let first_line = main_content.lines().next().unwrap_or("");
58 + if existing.contains(first_line) {
59 + util::warn("Already has this template");
60 + return Ok(());
61 + }
62 +
63 + // Append or create new file
64 + let new = if existing.trim().is_empty() {
65 + combined
66 + } else {
67 + format!("{}\n{}", existing.trim(), combined)
68 + };
69 +
70 + fs::write(path, new)?;
71 + util::ok(&format!(
72 + "Added {name} template (with base templates) to .gitignore"
73 + ));
74 + } else {
75 + util::err(&format!("Unknown template: {name}"));
76 + util::dim("Available: node, python, rust, go, java, web, macos, windows, linux, ide");
77 + }
|
|
|
adding items after statements is confusing, since items exist from the start of the scope:
backpack/lib/src/ghk/commands/ignore.rs#L52
warning: adding items after statements is confusing, since items exist from the start of the scope
--> backpack/lib/src/ghk/commands/ignore.rs:52:13
|
52 | use std::fmt::Write as _;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements
= note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
backpack/lib/src/ghk/commands/ignore.rs#L44
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> backpack/lib/src/ghk/commands/ignore.rs:44:5
|
44 | / match main {
45 | | Some(main_content) => {
46 | | let path = ".gitignore";
47 | | let existing = fs::read_to_string(path).unwrap_or_default();
... |
81 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else
= note: `-W clippy::single-match-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::single_match_else)]`
help: try
|
44 ~ if let Some(main_content) = main {
45 + let path = ".gitignore";
46 + let existing = fs::read_to_string(path).unwrap_or_default();
47 +
48 + // Build final template: main + all base templates
49 + let mut combined = format!("# {name}\n{main_content}");
50 +
51 + use std::fmt::Write as _;
52 + for (base_name, base_content) in BASE_TEMPLATES {
53 + let _ = write!(combined, "\n# base: {base_name}\n{base_content}");
54 + }
55 +
56 + // If .gitignore already contains the first line of the main template, skip
57 + let first_line = main_content.lines().next().unwrap_or("");
58 + if existing.contains(first_line) {
59 + util::warn("Already has this template");
60 + return Ok(());
61 + }
62 +
63 + // Append or create new file
64 + let new = if existing.trim().is_empty() {
65 + combined
66 + } else {
67 + format!("{}\n{}", existing.trim(), combined)
68 + };
69 +
70 + fs::write(path, new)?;
71 + util::ok(&format!(
72 + "Added {name} template (with base templates) to .gitignore"
73 + ));
74 + } else {
75 + util::err(&format!("Unknown template: {name}"));
76 + util::dim("Available: node, python, rust, go, java, web, macos, windows, linux, ide");
77 + }
|
|
|
multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-result`: 0.3.4, 0.4.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-result`: 0.3.4, 0.4.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-link`: 0.1.3, 0.2.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-link`: 0.1.3, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-core`: 0.61.2, 0.62.2:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-core`: 0.61.2, 0.62.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror`: 1.0.69, 2.0.18:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `thiserror`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `getrandom`: 0.2.17, 0.3.4:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `getrandom`: 0.2.17, 0.3.4
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `console`: 0.15.11, 0.16.2:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `console`: 0.15.11, 0.16.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
= note: `-W clippy::multiple-crate-versions` implied by `-W clippy::cargo`
= help: to override `-W clippy::cargo` add `#[allow(clippy::multiple_crate_versions)]`
|
|
multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-result`: 0.3.4, 0.4.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-result`: 0.3.4, 0.4.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-link`: 0.1.3, 0.2.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-link`: 0.1.3, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `windows-core`: 0.61.2, 0.62.2:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `windows-core`: 0.61.2, 0.62.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `thiserror`: 1.0.69, 2.0.18:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `thiserror`: 1.0.69, 2.0.18
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `openssl-probe`: 0.1.6, 0.2.1
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `getrandom`: 0.2.17, 0.3.4:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `getrandom`: 0.2.17, 0.3.4
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
|
|
multiple versions for dependency `console`: 0.15.11, 0.16.2:
backpack/lib/src/lib.rs#L1
warning: multiple versions for dependency `console`: 0.15.11, 0.16.2
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
= note: `-W clippy::multiple-crate-versions` implied by `-W clippy::cargo`
= help: to override `-W clippy::cargo` add `#[allow(clippy::multiple_crate_versions)]`
|
|
Auto Fix:
entrypoint.sh#L4
cargo format
|