fix: Clippy warnings: string formatting, match arms, unused imports, dead_code in tests (#24)

Author: yonas

.gitignore

@@ -28,3 +28,6 @@ coverage/
 
 # Crash dumps
 **/*.core
+
+# coverage data
+**/*.profraw

backpack/cli/src/commands/maintain/mod.rs

@@ -2,11 +2,9 @@ use clap::Parser;
 use rootcause::hooks::Hooks;
 use rootcause_backtrace::BacktraceCollector;
 use tracing::instrument;
-use tracing_subscriber::{EnvFilter, fmt, prelude::*};
 
 use github_bot_lib::cli::Args;
 use github_bot_lib::github;
-use github_bot_lib::log::{LogFormat, Printer, ScreenLogger, SimpleLogger, Verbosity};
 
 #[instrument(level = "debug", target = "errors::rootcause", name = "run")]
 pub fn run(repo: String, action: &Option<String>) -> anyhow::Result<()> {

backpack/cli/src/main.rs

@@ -193,7 +193,9 @@ async fn main() -> anyhow::Result<()> {
             )
             .await;
 
-            wip::run(*no_push, *no_diff, *rewind);
+            if let Err(e) = wip::run(*no_push, *no_diff, *rewind) {
+                logger.err(&format!("{e}"));
+            }
 
             plugins::broadcast_event(&plugins, Event::CliCommandExecutionEnd).await;
 

backpack/lib/src/cli/mod.rs

@@ -32,6 +32,7 @@ pub struct Args {
 impl Args {
     /// The "Smart Default" logic.
     /// Priority: 1. CLI Argument, 2. Git Discovery, 3. Hardcoded Fallback
+    #[must_use]
     pub fn resolve_repo(provided: &Option<String>) -> String {
         if let Some(repo) = provided {
             return repo.clone();
@@ -58,7 +59,7 @@ impl Args {
             if parts.len() >= 2 {
                 let repo_name = parts.last()?;
                 let owner = parts.get(parts.len() - 2)?;
-                return Some(format!("{}/{}", owner, repo_name));
+                return Some(format!("{owner}/{repo_name}"));
             }
         }
         None

backpack/lib/src/ghk/app.rs

@@ -21,10 +21,10 @@ pub fn run(cli: Args) -> Result<()> {
 
         // Save config to mark first run complete
         let cfg = config::Config::default();
-        if let Err(_e) = cfg.save() {
+        if let Err(e) = cfg.save() {
             // In production, we might want to log this differently.
             #[cfg(debug_assertions)]
-            eprintln!("Debug: Failed to save config: {}", _e);
+            eprintln!("Debug: Failed to save config: {e}");
         }
     }
 
@@ -52,7 +52,10 @@ pub fn run(cli: Args) -> Result<()> {
             GitCommands::Ignore { template } => crate::ghk::commands::ignore::run(template),
             GitCommands::License { kind } => crate::ghk::commands::license::run(kind),
             GitCommands::Branch { name } => crate::ghk::commands::branch::run(name),
-            GitCommands::Completions { shell } => crate::ghk::commands::completions::run(shell),
+            GitCommands::Completions { shell } => {
+                crate::ghk::commands::completions::run(shell);
+                Ok(())
+            }
         },
         _ => Ok(()),
     }

backpack/lib/src/ghk/commands/branch.rs

@@ -8,49 +8,46 @@ pub fn run(name: Option<String>) -> Result<()> {
         bail!("Not a git repository");
     }
 
-    match name {
+    if let Some(branch) = name {
         // Switch to branch
-        Some(branch) => {
-            util::info(&format!("Switching to {branch}..."));
+        util::info(&format!("Switching to {branch}..."));
 
-            let status = Command::new("git").args(["checkout", &branch]).status()?;
+        let status = Command::new("git").args(["checkout", &branch]).status()?;
+
+        if status.success() {
+            util::ok(&format!("Now on {branch}"));
+        } else {
+            // Maybe it's a new branch?
+            util::info("Branch not found, creating it...");
+            let status = Command::new("git")
+                .args(["checkout", "-b", &branch])
+                .status()?;
 
             if status.success() {
-                util::ok(&format!("Now on {branch}"));
+                util::ok(&format!("Created and switched to {branch}"));
             } else {
-                // Maybe it's a new branch?
-                util::info("Branch not found, creating it...");
-                let status = Command::new("git")
-                    .args(["checkout", "-b", &branch])
-                    .status()?;
-
-                if status.success() {
-                    util::ok(&format!("Created and switched to {branch}"));
-                } else {
-                    util::err("Could not switch branch");
-                }
+                util::err("Could not switch branch");
             }
         }
+    } else {
         // List branches
-        None => {
-            let current = git::currentbranch().unwrap_or_default();
-
-            let output = Command::new("git").args(["branch", "--list"]).output()?;
-
-            let text = String::from_utf8_lossy(&output.stdout);
-
-            println!();
-            util::info("Branches:");
-            for line in text.lines() {
-                let name = line.trim().trim_start_matches("* ");
-                if name == current {
-                    println!("  \x1b[32m▶ {}\x1b[0m (current)", name);
-                } else {
-                    util::dim(&format!("  {name}"));
-                }
+        let current = git::currentbranch().unwrap_or_default();
+
+        let output = Command::new("git").args(["branch", "--list"]).output()?;
+
+        let text = String::from_utf8_lossy(&output.stdout);
+
+        println!();
+        util::info("Branches:");
+        for line in text.lines() {
+            let name = line.trim().trim_start_matches("* ");
+            if name == current {
+                println!("  \x1b[32m▶ {name}\x1b[0m (current)");
+            } else {
+                util::dim(&format!("  {name}"));
             }
-            println!();
         }
+        println!();
     }
 
     Ok(())

backpack/lib/src/ghk/commands/clone.rs

@@ -21,8 +21,13 @@ pub fn run(repo: Option<String>, dir: Option<String>) -> Result<()> {
     util::info(&format!("Cloning {reponame}..."));
     gh::clonerepo(&reponame, dir.as_deref())?;
 
-    let dirname =
-        dir.unwrap_or_else(|| reponame.split('/').last().unwrap_or(&reponame).to_string());
+    let dirname = dir.unwrap_or_else(|| {
+        reponame
+            .split('/')
+            .next_back()
+            .unwrap_or(&reponame)
+            .to_string()
+    });
 
     util::ok(&format!("Downloaded to '{dirname}'"));
     util::dim(&format!("cd {dirname} to start working"));

backpack/lib/src/ghk/commands/completions.rs

@@ -1,11 +1,10 @@
 use crate::cli::Args;
-use anyhow::Result;
+
 use clap::CommandFactory;
 use clap_complete::{Shell, generate};
 use std::io;
 
-pub fn run(shell: Shell) -> Result<()> {
+pub fn run(shell: Shell) {
     let mut cmd = Args::command();
     generate(shell, &mut cmd, "github-bot", &mut io::stdout());
-    Ok(())
 }

backpack/lib/src/ghk/commands/config.rs

@@ -15,14 +15,17 @@ pub fn run(key: Option<String>, value: Option<String>) -> Result<()> {
                 "  editor  = {editor}",
                 editor = cfg.editor.as_deref().unwrap_or("(default)")
             ));
-            util::dim(&format!("  org  = {org}", org = cfg.org.as_deref().unwrap_or("")));
+            util::dim(&format!(
+                "  org  = {org}",
+                org = cfg.org.as_deref().unwrap_or("")
+            ));
             println!();
             util::dim(&format!("Config file: {}", Config::path().display()));
             println!();
         }
         // Show one setting
         (Some(k), None) => match cfg.get(&k) {
-            Some(v) => println!("{}", v),
+            Some(v) => println!("{v}"),
             None => util::warn(&format!("Unknown setting: {k}")),
         },
         // Set a value

backpack/lib/src/ghk/commands/diff.rs

@@ -27,7 +27,6 @@ pub fn run() -> Result<()> {
         match origin {
             '+' => print!("\x1b[32m{text}\x1b[0m"), // addition
             '-' => print!("\x1b[31m{text}\x1b[0m"), // deletion
-            ' ' => print!("{text}"),                // context
 
             // hunk header
             'H' => print!("\x1b[1;36m{text}\x1b[0m"),
@@ -38,7 +37,7 @@ pub fn run() -> Result<()> {
             // metadata (index, mode changes, etc.)
             'B' | 'M' => print!("\x1b[33m{text}\x1b[0m"),
 
-            // fallback
+            // context or fallback
             _ => print!("{text}"),
         }