feature: Add support to opt-out from zone aware routing via Ingress/RouteGroup#4049
Open
greeshma1196 wants to merge 5 commits into
Open
feature: Add support to opt-out from zone aware routing via Ingress/RouteGroup#4049greeshma1196 wants to merge 5 commits into
greeshma1196 wants to merge 5 commits into
Conversation
Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>
Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>
Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>
Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>
- add missing test covering defaultBackend + opt-out - change EnableZoneAwareness from string to bool Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>
szuecs
requested changes
Jun 6, 2026
| LBEndpoints []*LBEndpoint | ||
|
|
||
| // DisableZoneAwareness indicates that the route should not be processed with zone awareness. | ||
| DisableZoneAwareness bool |
Member
There was a problem hiding this comment.
I don't think it's a good idea to have it in eskip.
It has nothing to do with the language.
Member
|
In general I think we might want to pass the new filter through the ingress context and routegroup context instead of a parameter of a function. The parameter feels disconnected to the other. |
Collaborator
Author
|
@szuecs If we pass the annotation through ingress/routegroup context, RouteSRV still needs to know whether to filter this route or not. In order for that to work we need to set a field within the Route struct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the annotation
zalando.org/traffic-zone-aware: "false"on Ingress and RouteGroup resources. When set, the resource receives all endpoints across all zones, bypassing zone filtering both at the dataclient layer (endpoint fetch) and at the routesrv layer (per-zone route serving).Usage:
Tasks
zalando.org/traffic-zone-awareannotation constant in the kubernetes packageeskip.RoutewithEnableZoneAwarenessfield to carry the annotation value through the route pipeline toroutesrvGetEndpointSlicesByServiceandGetEndpointSlicesByTargetinclusterstate.goto acceptzoneAwareTrafficparam and skip zone filtering when value is"false"convertPathRuleV1) and default backend conversion (convertDefaultBackendV1) to read the annotation, pass it to endpoint fetch, and setr.EnableZoneAwarenessapplyServiceBackend) to read the annotation, pass it to endpoint fetch, and setr.EnableZoneAwarenessgetRouteForZoneinroutesrv/polling.goto return the route unmodified whenEnableZoneAwareness == "false"eu-central-1a: one opted out (expects all endpoints across zones), one default (expects only zone-local endpoints)filterRoutesByZonecovering opt-out scenarios: both routes opted out, opt-out mixed with normal route, and opt-out with a below-threshold zoneref: #3971