Wrap canvas tab bar and make Start-session button icon-only#117
Merged
Conversation
Canvas top-panel tabs now wrap onto multiple rows and grow the bar's height instead of scrolling horizontally. The Start-session button is now an icon-only play button with a tooltip, matching the Share/Archive buttons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: dfa4e8a9-3fe0-497d-9e07-2e654043d2cb
There was a problem hiding this comment.
Pull request overview
Updates the canvas header to wrap tabs and use a consistent icon-only Start-session action.
Changes:
- Wraps canvas tabs onto multiple rows.
- Adds a play SVG to the Start-session button.
- Updates the related Playwright assertion.
Show a summary per file
| File | Description |
|---|---|
src/Client/index.html |
Updates tab wrapping and launch-button styling. |
src/Client/CanvasPane.fs |
Adds and renders the play icon. |
src/Tests/CanvasPhase4Tests.fs |
Updates the Start-session button test. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Medium
| display: flex; | ||
| gap: 2px; | ||
| overflow-x: auto; | ||
| flex-wrap: wrap; |
| display: flex; | ||
| gap: 2px; | ||
| overflow-x: auto; | ||
| flex-wrap: wrap; |
Comment on lines
+183
to
+184
| let! title = launchBtn.GetAttributeAsync("title") | ||
| Assert.That(title, Does.Contain("Start a session"), "Button tooltip should describe starting a session") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The canvas top-panel tab bar scrolled horizontally when many tabs were open, hiding tabs off-screen. The Start-session button also used a text label (
▶ Start session), which was inconsistent with the icon-only Share and Archive buttons in the same bar.Changes
src/Client/index.html):.canvas-tab-groupnow usesflex-wrap: wrapinstead ofoverflow-x: auto, so tabs flow onto multiple rows and grow the bar's height rather than scrolling..canvas-tab-baraligns items toflex-startto accommodate the taller, multi-row layout.src/Client/CanvasPane.fs): replaced the▶ Start sessiontext with a newplayIcon(a filled play-triangle SVG) styled likeshareIcon(btn-icon,currentColor), with a tooltip preserved viaprop.title. Added.canvas-launch-btn .btn-iconsizing (14×14) inindex.html.Tests
src/Tests/CanvasPhase4Tests.fsto match the icon-only button.