Skip to content

Add ability to dock player to top or bottom of page #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterwilsoncc merged 13 commits into from
Jun 19, 2026
+227 −44
Merged

Add ability to dock player to top or bottom of page #331

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c43ffd9
Implements initial ability to dock the player to top or bottom of page
wadebekker Jan 2, 2025
face825
Merge branch 'develop' into feature/dock-player-position
sanketio Aug 8, 2025
55c19ca
Add ARIA attributes to the elements
sanketio Aug 8, 2025
d91e34a
Make id unique and only allow docking on single posts
sanketio Aug 8, 2025
8ae18f6
Fix formatting for consistency
sanketio Aug 8, 2025
53df906
Adjust width of the podcast block in the editor
sanketio Aug 8, 2025
ad06f10
Merge branch 'develop' into feature/dock-player-position
peterwilsoncc Aug 14, 2025
607ff03
Merge branch 'develop' into feature/dock-player-position
sanketio Sep 5, 2025
f1108fc
Remove editor changes for the dock position
sanketio Sep 5, 2025
26a1dd3
Remove editor changes relted to podcast block for docked setting
sanketio Sep 8, 2025
1c23c66
Remove unnecessary dependency
sanketio Sep 8, 2025
8e18db2
Replace is_single with is_singular
sanketio Sep 15, 2025
c19ba07
Merge branch 'develop' into feature/dock-player-position
peterwilsoncc Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion assets/js/blocks.js
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,12 @@ export default registerBlockType(
displayEpisodeType: {
type: 'boolean',
default: false,
}
},
isDocked: {
type: 'string',
default: 'none',
enum: ['none', 'top', 'bottom'],
},
},
transforms,

Expand Down
79 changes: 79 additions & 0 deletions assets/js/blocks/podcast/index.scss
View file
Open in desktop

@peterwilsoncc peterwilsoncc Jan 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code in this file uses tabs for intending, whereas the existing code is using spaces. Are you able to switch to spaces for consistency.

Original file line number Diff line number Diff line change
@@ -1,7 +1,84 @@
body.has-docked-bottom {
padding-bottom: 150px;
&.docked-in-editor .docked-bottom {
bottom: 24px;
}
}

body.has-docked-top {
padding-top: 150px;

&.docked-in-editor {
padding-top: 0px;
}
&.docked-in-editor .editor-styles-wrapper {
padding-top: 150px;
}
&.docked-in-editor .docked-top {
top: 60px;
}

&.logged-in.admin-bar {
padding-top: 182px;
}

&.logged-in.admin-bar .docked-top {
top: 32px;
}
}

.wp-block-podcasting-podcast-outer {
border: 1px solid #707070;
border-radius: 4px;
padding: 20px;

&.docked-bottom {
margin: 0;
background-color: var(--wp--preset--color--base);
position: fixed;
bottom: 0;
left: 0;
right: 0;
z-index: 34;
border-radius: 4px 4px 0px 0px;
max-width: initial;

& .wp-block-podcasting-podcast__container {
margin-bottom: 0px;
}

& .wp-block-podcasting-podcast__details {
width: 100%;
}

& .wp-block-podcasting-podcast__toggle-details-button {
margin-bottom: 20px;
}
}

&.docked-top {
margin: 0;
background-color: var(--wp--preset--color--base);
position: fixed;
top: 0;
left: 0;
right: 0;
z-index: 34;
border-radius: 0px 0px 4px 4px;
max-width: initial;

& .wp-block-podcasting-podcast__container {
margin-bottom: 0px;
}

& .wp-block-podcasting-podcast__details {
width: 100%;
}

& .wp-block-podcasting-podcast__toggle-details-button {
margin-bottom: 20px;
}
}
}

.wp-block-podcasting-podcast__container {
Expand All @@ -13,9 +90,11 @@
}

.wp-block-podcasting-podcast__show-art {
display: none;
margin-bottom: 20px;

@media (min-width: 768px) {
display: block;
flex-basis: 100px;
margin-bottom: 0;
margin-right: 20px;
Expand Down
Loading
Loading