Skip to content

fix: preserve macOS Ctrl+5 prompt jump - #1137

Open
1jehuang wants to merge 1 commit into
masterfrom
fix/1131-macos-ctrl-5
Open

fix: preserve macOS Ctrl+5 prompt jump#1137
1jehuang wants to merge 1 commit into
masterfrom
fix/1131-macos-ctrl-5

Conversation

@1jehuang

@1jehuang 1jehuang commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • stop rewriting macOS Ctrl+5 into the legacy Ctrl+] alias
  • preserve the documented fifth-most-recent prompt jump
  • retain the unambiguous Esc to Ctrl+[ fallback

Verification

  • cargo test -p jcode-tui --lib prompt_jump_ctrl_digit (2 passed)
  • cargo check -p jcode-tui

The affected rewrite is macOS-only, so final platform behavior remains subject to macOS CI/review validation.

Fixes #1131

--- — Jcode agent (automated triage), on behalf of @1jehuang

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Greptile Summary

This change preserves Ctrl+5 on macOS so users can jump to the fifth-most-recent prompt, without changing Ctrl+[ or the Ctrl+Esc compatibility fallback. Direct normalization checks and application-level prompt-jump tests confirmed that the intended key paths continue to work.

Confidence Score: 5/5

Safe to merge: the changed key-normalization behavior preserves Ctrl+5 and retains the existing Ctrl+[ fallback.

No defects were found. Executable before-and-after normalization checks and focused application-level tests exercised the affected Ctrl+5, Ctrl+[, and Ctrl+Esc paths successfully.

Files Needing Attention: No files need further attention.

T-Rex T-Rex Logs

What T-Rex did

  • Ran an executable Rust harness to compare pre-change and post-change Ctrl+5 normalization behavior.
  • Observed that Ctrl+5 normalization changed from Char(']') before the change to Char('5') after the change, while Ctrl+[ remains Char('[') and Ctrl+Esc continues to normalize to Char('[').
  • Executed cargo test -p jcode-tui test_prompt_jump_ctrl --lib -- --nocapture and verified the app-level tests passed.
  • Confirmed via the test results that the prompt-jump tests for Ctrl+5 and Ctrl+[ passed (2 passed, 0 failed).

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "fix: preserve macOS Ctrl+5 prompt jump (..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS: Ctrl+5 prompt-rank jump is dead; a legacy Ctrl+] alias consumes it before any handler runs

1 participant