refactor(usage_limit): extract period validation#42
Open
akostadinov-bot[bot] wants to merge 2 commits into
Open
refactor(usage_limit): extract period validation#42akostadinov-bot[bot] wants to merge 2 commits into
akostadinov-bot[bot] wants to merge 2 commits into
Conversation
Extract single-period validation from save into validate_single_period! for clarity and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… entry Rubocop is not in the Gemfile, so qlty's package_file lookup fails with "rubocop: not found". Pin version directly in qlty.toml. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UsageLimit.saveinto a dedicatedvalidate_single_period!private class methodsaveeasier to read by separating validation from the API update logicTest plan
usagelimit_spec.rbtests pass (saves, period validation errors)usage_limit.rbcovered including the new method🤖 Generated with Claude Code