Skip to content

allow customer oracle client version #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akostadinov wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −7
Open

allow customer oracle client version #4327

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1425c4c
allow customer oracle client version
akostadinov Jun 25, 2026
6b73775
update default oracle client version
akostadinov Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions script/oracle/install-instantclient-packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@ declare -a packages=(instantclient-sdk instantclient-odbc)

function install_pkg {
local package="$1"
local path="vendor/oracle"
local zip="${package}-${oracle_version}.zip"
local file="vendor/oracle/${zip}"
local file="$path/${zip}"
local existing_file="$path/${package}-"*".zip"

@qltysh qltysh Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace expansions and globs are literal in assignments. Quote it or use an array. [shellcheck:2125]


if [ -f "${file}" ]; then
echo "[OK] ${file} already present"
if [ -f "${existing_file}" ]; then
echo "[OK] ${existing_file} already present"
file="${existing_file}"
else
echo "[INFO] Downloading ${zip} from Oracle servers"
wget "${oracle_otn}/${zip}" -O "${file}"
Expand Down