Replace jQuery 1 with jQuery 3 as global $#4333
Open
josemigallas wants to merge 6 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
josemigallas
force-pushed
the
THREESCALE-15320_replace_jquery_1_with_3
branch
from
July 14, 2026 10:45
5337343 to
b96b669
Compare
josemigallas
force-pushed
the
THREESCALE-15320_replace_jquery_1_with_3
branch
from
July 16, 2026 06:48
5dbdfd4 to
b96b669
Compare
❌ 3 blocking issues (5 total)
|
| } | ||
|
|
||
| if (el) cache.set(el, instance) | ||
| return instance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THREESCALE-15320: Replace jQuery 3 as default in admin portal
Since jQuery 3 is already shipped with rails, this migration renders webpack's jQuery redundant, so we're removing it too. Now there is only one and only jQuery available globally and that is the one provided by rails-jquery
gem.Spoiler alert: there are exceptions (but they are really minor).
This is the current state of jQuery:
vendor/colorbox.js)window.colorboxThreeScale.APIDocs.jQuerycdn_asset)$)Verification steps:
So there is not really a way to absolutely 100% verify this, but if there was something wrong, admin portal would break in some way or another and it doesn't.
Compatibility-wise, the codebase is now 100% compatible with jQuery 3 as Claude looked up every single use of $/jQuery and updated the methods that were removed in v3.