THREESCALE-15318 - Bump faraday gem [2.15]#4341
Closed
akostadinov-bot[bot] wants to merge 1 commit into
Closed
Conversation
Backport of PR #4330 to the 3scale-2.15-stable branch. Update Faraday version constraint to >= 2.14.3 which includes improvements in nested query string handling. Also updates pisoni to ~> 1.31 (v1.31.0 relaxes the faraday upper bound). Additional dependency pins: - uri < 1.0.0: uri 1.0.0 changes the default parser from RFC2396 to RFC3986, breaking URI::DEFAULT_PARSER usage across the codebase. - connection_pool ~> 2.2, < 3: connection_pool 3.0 changes #with from positional to keyword-only args, breaking redis-client 0.22.2. Assisted-By: claude-opus-4-6 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This is not so easy Mr Bot. The patched version of Faraday requires Ruby 3. |
Contributor
|
This should not be needed, idk why he didn't close it. See the actual JIRA ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #4330 to the
3scale-2.15-stablebranch.faradayupdated from~> 2.0, <= 2.9(resolved 2.8.1) to~> 2.0, >= 2.14.3(resolved 2.14.3)pisoniupdated from~> 1.30to~> 1.31(v1.31.0 relaxes the faraday upper bound)Additional dependency pins
uri < 1.0.0— uri 1.0.0+ changes the default parser from RFC2396 to RFC3986, removingURI::DEFAULT_PARSERandURI.decodewhich are used across the codebase. Pin to keep current behavior; upgrade separately.connection_pool ~> 2.2, < 3— connection_pool 3.0 switches#withfrom positional to keyword-only arguments, breaking redis-client 0.22.2. Pin until redis-client is upgraded.Transitive dependency updates (via
bundle lock)faraday-net_http3.0.2 -> 3.4.4faraday-net_http_persistent2.1.0 -> 2.3.1net-http-persistent4.0.2 -> 4.0.8connection_pool2.4.1 -> 2.5.5json2.7.1 -> 2.20.0net-http0.9.1,logger1.7.0,uri0.13.3Test plan
3scale-2.15-stablebranch