Skip to content

THREESCALE-15318 - Bump faraday gem [2.15]#4341

Closed
akostadinov-bot[bot] wants to merge 1 commit into
3scale-2.15-stablefrom
THREESCALE-15318-bump-faraday-2.15
Closed

THREESCALE-15318 - Bump faraday gem [2.15]#4341
akostadinov-bot[bot] wants to merge 1 commit into
3scale-2.15-stablefrom
THREESCALE-15318-bump-faraday-2.15

Conversation

@akostadinov-bot

Copy link
Copy Markdown
Contributor

Summary

Backport of #4330 to the 3scale-2.15-stable branch.

  • JIRA: THREESCALE-15318
  • Gem: faraday updated from ~> 2.0, <= 2.9 (resolved 2.8.1) to ~> 2.0, >= 2.14.3 (resolved 2.14.3)
  • Gem: pisoni updated from ~> 1.30 to ~> 1.31 (v1.31.0 relaxes the faraday upper bound)

Additional dependency pins

  • uri < 1.0.0 — uri 1.0.0+ changes the default parser from RFC2396 to RFC3986, removing URI::DEFAULT_PARSER and URI.decode which are used across the codebase. Pin to keep current behavior; upgrade separately.
  • connection_pool ~> 2.2, < 3 — connection_pool 3.0 switches #with from positional to keyword-only arguments, breaking redis-client 0.22.2. Pin until redis-client is upgraded.

Transitive dependency updates (via bundle lock)

  • faraday-net_http 3.0.2 -> 3.4.4
  • faraday-net_http_persistent 2.1.0 -> 2.3.1
  • net-http-persistent 4.0.2 -> 4.0.8
  • connection_pool 2.4.1 -> 2.5.5
  • json 2.7.1 -> 2.20.0
  • Added: net-http 0.9.1, logger 1.7.0, uri 0.13.3

Test plan

  • CI passes on the 3scale-2.15-stable branch
  • Verify faraday resolves to 2.14.3 in the lockfile
  • Verify no runtime regressions in API calls that use faraday

Backport of PR #4330 to the 3scale-2.15-stable branch.

Update Faraday version constraint to >= 2.14.3 which includes
improvements in nested query string handling. Also updates
pisoni to ~> 1.31 (v1.31.0 relaxes the faraday upper bound).

Additional dependency pins:
- uri < 1.0.0: uri 1.0.0 changes the default parser from RFC2396 to
  RFC3986, breaking URI::DEFAULT_PARSER usage across the codebase.
- connection_pool ~> 2.2, < 3: connection_pool 3.0 changes #with from
  positional to keyword-only args, breaking redis-client 0.22.2.

Assisted-By: claude-opus-4-6
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jlledom

jlledom commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This is not so easy Mr Bot. The patched version of Faraday requires Ruby 3.

@akostadinov

akostadinov commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This should not be needed, idk why he didn't close it. See the actual JIRA ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants