Upgrade Developer portal's default template to jQuery 3.7.1#4348
Upgrade Developer portal's default template to jQuery 3.7.1#4348josemigallas wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… must upgrade their templates themselves)
❌ 61 blocking issues (63 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| // url address might already include some parameters | ||
| const connector = url.includes('?') ? '&' : '?' | ||
| let href = url.concat(connector, jquery1('table tbody .select :checked').serialize()) | ||
| let href = url.concat(connector, $('table tbody .select :checked').serialize()) |
There was a problem hiding this comment.
Found 4 issues:
1. Unsafe argument of type any assigned to a parameter of type string. [eslint:@typescript-eslint/no-unsafe-argument]
2. Unsafe call of an any typed value. [eslint:@typescript-eslint/no-unsafe-call]
3. Unsafe call of an any typed value. [eslint:@typescript-eslint/no-unsafe-call]
4. Unsafe member access .serialize on an any value. [eslint:@typescript-eslint/no-unsafe-member-access]
|
|
||
| function updateBulkOperationsCard () { | ||
| const bulk = jquery1('#bulk-operations') | ||
| const bulk = $('#bulk-operations') |
| * Called every time a CMS section is selected in the sidebar, including first render. | ||
| */ | ||
| jQuery1(document).on('cms-template:init', () => { | ||
| $(document).on('cms-template:init', () => { |
There was a problem hiding this comment.
| setUpPjax() | ||
|
|
||
| jQuery1('#cms_template_content_type, #cms_template_liquid_enabled').trigger('change') | ||
| $('#cms_template_content_type, #cms_template_liquid_enabled').trigger('change') |
There was a problem hiding this comment.
| }) | ||
|
|
||
| jQuery1(document).on('cms-sidebar:update', () => { | ||
| $(document).on('cms-sidebar:update', () => { |
| $(document).pjax!('#cms-sidebar .cms-sidebar-listing a', '#tab-content', { timeout: 3000 }) | ||
|
|
||
| jQuery1(document) | ||
| $(document) |
| }) | ||
| .on('pjax:end', (event) => { | ||
| jQuery1(event.target).trigger('cms-template:init') | ||
| $(event.target).trigger('cms-template:init') |
There was a problem hiding this comment.
Found 4 issues:
1. Unsafe member access .trigger on an any value. [eslint:@typescript-eslint/no-unsafe-member-access]
2. Unsafe call of an any typed value. [eslint:@typescript-eslint/no-unsafe-call]
3. Unsafe call of an any typed value. [eslint:@typescript-eslint/no-unsafe-call]
4. Unsafe member access .target on an any value. [eslint:@typescript-eslint/no-unsafe-member-access]
| // This link will load its content into a colorbox modal | ||
| $(document).on('click', 'a.fancybox, a.colorbox', (e) => { | ||
| jQuery1(e.currentTarget as HTMLAnchorElement).colorbox({ open: true }) | ||
| const { title, href } = e.currentTarget as HTMLAnchorElement |
| } else { | ||
| // TODO: can we generate this data without reading the DOM? Using selectedItems as a prop | ||
| return url.concat(connector, jquery1('table tbody .pf-c-table__check input:checked').serialize()) | ||
| return url.concat(connector, $('table tbody .pf-c-table__check input:checked').serialize()) |
There was a problem hiding this comment.
Found 4 issues:
1. Unsafe argument of type any assigned to a parameter of type string. [eslint:@typescript-eslint/no-unsafe-argument]
2. Unsafe call of an any typed value. [eslint:@typescript-eslint/no-unsafe-call]
3. Unsafe call of an any typed value. [eslint:@typescript-eslint/no-unsafe-call]
4. Unsafe member access .serialize on an any value. [eslint:@typescript-eslint/no-unsafe-member-access]
| } | ||
|
|
||
| if (el) cache.set(el, instance) | ||
| return instance |
1 participant
What this PR does / why we need it:
I really doesn't do much. It changes the jQuery version for any new Developer portals but also makes 3.7.1 available for manual upgrade of existing ones.
Which issue(s) this PR fixes
THREESCALE-15551: Upgrade Developer Portal to jQuery 3.7.x
Verification steps
jQuery().jquery.Special notes for your reviewer:
This has zero impact on production or existing accounts.