Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The PR appears safe to merge; no new actionable issue was found. SummaryLoads pending Stalker seasons when saved progress exists, fills season counts, and updates the picker and play button as episodes arrive.
Reviews (2) · Last reviewed commit: "fix(stalker): address series progress re..." · Reviewed by Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb9a79c2e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d progress Signed-off-by: Pere Muñoz <peremunozfiguerol33@gmail.com>
eb9a79c to
1fe616e
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fe616ee4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| keys | ||
| .slice(keys.indexOf(lastWatchedKey) + 1) |
There was a problem hiding this comment.
Natural-sort season keys before selecting the successor
When a Stalker provider omits season_number and returns named seasons out of order, mapVodSeriesEpisodes() keeps those names as keys, and the container's numeric sort does not reorder them. For keys ['Season 2', 'Season 1', 'Season 3'], with Season 1 watched and the other two unwatched, this slice now selects Season 3; getSeriesNextUp() correctly targets Season 2, and the previous fallback also selected Season 2. Apply the shared natural season order before finding the last-watched index and its successor.
Useful? React with 👍 / 👎.
What changed
StalkerVodSeasonEpisodeLoader.hydrateForSavedProgress), so the season picker displays total and watched episode counts per season and saved progress is reconciled across seasons.getStalkerSeriesQuickStartButton(stalker-series-quick-start.ts) so that once episodes in a regular season have been watched, earlier unloaded or skipped seasons do not override the next unwatched episode after the last watched episode (e.g., watchingS04E01–S04E02offersS04E03, and finishing Season 4 advances to an unloaded Season 5 instead of wrapping back toS01E01).resolveAutoSelectedSeason(season-auto-select.util.ts) andcreateSeasonAutoSelectState(season-auto-select.state.ts) to prefer the season of the first unwatched episode after the last watched episode and re-resolve auto-selection as lazy VOD seasons finish hydrating (while preserving manual season tab selections and local watched toggles).Why
Fixes #2123
When opening a multi-season Stalker lazy VOD series (
is_series=1) with saved playback progress in later seasons, only Season 1 was loaded initially. As a result:S01E01/S02E01) instead of continuing from the first unwatched episode after the last watched episode (such asS04E03afterS04E02).Release note
.changes/Checks
pnpm run lintand the affectedpnpm nx test <project>pass