Repository navigation
fix(ui): stop vertical overscroll in standalone apps - #2248
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bundle ReportChanges will increase total bundle size by 667 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: iptvnator-rendererAssets Changed:
|
Contributor
 [Medium impact] This PR appears safe to merge. SummaryThis PR extends vertical overscroll prevention to standalone PWAs and the Android TV app.
No actionable issues were found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "fix(ui): stop vertical overscroll in sta..." · Reviewed by Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2248 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 1904 1904
Lines 101617 101617
Branches 24850 24850
=======================================
Hits 83204 83204
Misses 11128 11128
Partials 7285 7285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard can still bounce when dragged past its top or bottom in the installed app. This extends the vertical overscroll fix from #2227 to the workspace and its independent scrollers, including settings, sources, channel lists, catalogs, search, and the programme guide.
The rule applies in standalone PWA windows and the Android TV WebView. Browser tabs keep their existing behavior, and horizontal rails still pass vertical gestures to the page.
Validation
Startup bundle size
The nested scroll rules now load with the workspace route. The production build reproduces the CI measurement before the fix and passes the existing startup budget after it.
renderer.initialBytesAfter the move, 16 targeted E2E checks and 396 workspace unit tests passed. The PWA and Android APK built successfully, and the Android emulator confirmed that the workspace still stops vertical overscroll.
Release note
.changes/