Add unit tests for data_utils.py#197
Open
nikhiltelkar2005-glitch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue / Discussion:
Fixes Issue #166
Changes:
tests/test_data_utils.py— adds parametrized pytest unit tests fordata_utils.pyFurther Details:
Summary:
The file
WeatherRoutingTool/algorithms/data_utils.pycontained 5 testable units(
get_closest,distance,time_diffs,get_speed_from_arrival_time, andGridMixin)but had zero test coverage — no test file referenced it anywhere.
This PR adds a new test file
tests/test_data_utils.pywith:pytest.fixturedefinitions for reusable inputs (numpy arrays, route coordinates, datetime objects)get_closestcovering 5 edge cases (exact match, midpoint, beyond max, below min)get_speed_from_arrival_timecovering 3 cases usingunittest.mock.patchto mockRouteParams.get_per_waypoint_coordsBefore: No tests existed for
data_utils.py.After: 8 passing tests covering
get_closestandget_speed_from_arrival_time.Dependencies:
No new dependencies required. Tests use only existing packages:
pytest,numpy,astropy,unittest.mock(standard library).PR Checklist:
In the context of this PR, I: