Skip to content

fix(provider): keep video_url content in OpenAI Responses conversion #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3316891527 wants to merge 1 commit into
base: dev
Choose a base branch
from
+137 −0
Open

fix(provider): keep video_url content in OpenAI Responses conversion #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/com/ai/assistance/operit/api/chat/llmprovider/OpenAIResponsesProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,20 @@ object OpenAIResponsesPayloadAdapter {
}
}

"video_url", "input_video" -> {
val videoUrl =
part.optJSONObject("video_url")?.optString("url", "")
?: part.optString("video_url", "")
if (videoUrl.isNotEmpty()) {
convertedParts.put(
JSONObject().apply {
put("type", "input_video")
put("video_url", videoUrl)
}
)
}
}

else -> {
val rawText = part.optString("text", "")
if (rawText.isNotEmpty()) {
Expand Down
123 changes: 123 additions & 0 deletions .../test/java/com/ai/assistance/operit/api/chat/llmprovider/OpenAIResponsesVideoInputTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
package com.ai.assistance.operit.api.chat.llmprovider

import org.json.JSONArray
import org.json.JSONObject
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Test

class OpenAIResponsesVideoInputTest {
@Test
fun mapsChatCompletionsVideoUrlObjectToResponsesInputVideo() {
val request = chatRequest(
JSONArray()
.put(
JSONObject().apply {
put("type", "video_url")
put(
"video_url",
JSONObject().apply {
put("url", "data:video/mp4;base64,ZmFrZQ==")
},
)
},
)
.put(
JSONObject().apply {
put("type", "text")
put("text", "描述一下该视频")
},
),
)

val content = convertedContent(request)
assertEquals(2, content.length())
assertEquals("input_video", content.getJSONObject(0).getString("type"))
assertEquals(
"data:video/mp4;base64,ZmFrZQ==",
content.getJSONObject(0).getString("video_url"),
)
assertEquals("input_text", content.getJSONObject(1).getString("type"))
assertEquals("描述一下该视频", content.getJSONObject(1).getString("text"))
}

@Test
fun preservesResponsesInputVideoStringUrl() {
val request = chatRequest(
JSONArray().put(
JSONObject().apply {
put("type", "input_video")
put("video_url", "data:video/mp4;base64,ZmFrZQ==")
},
),
)

val video = convertedContent(request).getJSONObject(0)
assertEquals("input_video", video.getString("type"))
assertEquals("data:video/mp4;base64,ZmFrZQ==", video.getString("video_url"))
}

@Test
fun preservesResponsesInputVideoNestedUrl() {
val request = chatRequest(
JSONArray().put(
JSONObject().apply {
put("type", "input_video")
put(
"video_url",
JSONObject().apply {
put("url", "https://example.test/clip.mp4")
},
)
},
),
)

val video = convertedContent(request).getJSONObject(0)
assertEquals("input_video", video.getString("type"))
assertEquals("https://example.test/clip.mp4", video.getString("video_url"))
}

@Test
fun dropsEmptyVideoUrlInsteadOfEmittingBlankPart() {
val request = chatRequest(
JSONArray()
.put(
JSONObject().apply {
put("type", "video_url")
put("video_url", JSONObject())
},
)
.put(
JSONObject().apply {
put("type", "text")
put("text", "only text remains")
},
),
)

val content = convertedContent(request)
assertEquals(1, content.length())
assertEquals("input_text", content.getJSONObject(0).getString("type"))
assertFalse(content.toString().contains("input_video"))
}

private fun chatRequest(content: JSONArray): JSONObject =
JSONObject().apply {
put("model", "gpt-5.4")
put(
"messages",
JSONArray().put(
JSONObject().apply {
put("role", "user")
put("content", content)
},
),
)
}

private fun convertedContent(request: JSONObject): JSONArray {
val converted = OpenAIResponsesPayloadAdapter.toResponsesRequest(request)
return converted.getJSONArray("input").getJSONObject(0).getJSONArray("content")
}
}