Fix BLE enable check aborting scripts on firmware 2.0.0 - #210
Open
rihardsgrislis wants to merge 1 commit into
Open
rihardsgrislis wants to merge 1 commit into
rihardsgrislis wants to merge 1 commit into
Conversation
Shelly.getComponentConfig("ble") no longer returns a top-level `enable` key on firmware 2.0.0 (confirmed on a Plug S Gen3, 20260710-101146/2.0.0). The existing `!BLEConfig.enable` guard reads that absence as "Bluetooth is disabled" and returns before BLE.Scanner.Subscribe(), so the script never receives any advertisements.
The failure is silent: Script.GetStatus still reports running:true and nothing is logged past the initial error line, so an affected gateway looks healthy while relaying nothing. On the same device BLE.GetStatus reports flags ["advertising","scanning"] — Bluetooth is on, only the config shape changed.
Check for an explicit `false` instead. That still behaves correctly on Gen2 firmware (verified on a BLU Gateway, 1.7.5), which does send `enable: true`.
Contributor
|
@taulfsime will you give it an eye. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shelly.getComponentConfig("ble") no longer returns a top-level
enablekey on firmware 2.0.0 (confirmed on a Plug S Gen3, 20260710-101146/2.0.0). The existing!BLEConfig.enableguard reads that absence as "Bluetooth is disabled" and returns before BLE.Scanner.Subscribe(), so the script never receives any advertisements.The failure is silent: Script.GetStatus still reports running:true and nothing is logged past the initial error line, so an affected gateway looks healthy while relaying nothing. On the same device BLE.GetStatus reports flags ["advertising","scanning"] — Bluetooth is on, only the config shape changed.
Check for an explicit
falseinstead. That still behaves correctly on Gen2 firmware (verified on a BLU Gateway, 1.7.5), which does sendenable: true.