RTX 5090 compatibility guards for CompVis LDM variants#17329
Open
PiercingXX wants to merge 3 commits into
Open
RTX 5090 compatibility guards for CompVis LDM variants#17329PiercingXX wants to merge 3 commits into
PiercingXX wants to merge 3 commits into
Conversation
|
Hi, The AddMiDaS ImportError fallback is a no-op, but depth2img_image_conditioning() requires it to produce a 'midas_in' key, causing a KeyError when depth models are used without ldm.data.util. Severity: action required | Category: correctness How to fix: Disable depth2img when MiDaS missing Agent prompt to fix - you can give this to your LLM of choice:
Found by Qodo code review. FYI, Qodo is free for open-source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds defensive compatibility guards so webui can run on modern RTX 5090 + torch nightly stacks when the underlying implementation differs from expected attributes/modules.
Changes
Validation
Notes