Skip to content

Allow one to specify server endpoint in config #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shouya wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow one to specify server endpoint in config #74

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13735df
Allow one to specify server endpoint in config
shouya Jun 16, 2023
6a4426d
Fix KeyError
shouya Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aw_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,10 @@ def __init__(

server_host = host or server_config["hostname"]
server_port = port or server_config["port"]
self.server_address = "{protocol}://{host}:{port}".format(
default_server_address = "{protocol}://{host}:{port}".format(
protocol=protocol, host=server_host, port=server_port
)
self.server_address = server_config["endpoint"] or default_server_address
Copy link
Copy Markdown
Member

@ErikBjare ErikBjare Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a better name than endpoint (which imo is more something like /api/info, or a full path).

I've seen some APIs use baseurl, which I like.

Suggested change
self.server_address = server_config["endpoint"] or default_server_address
self.server_address = server_config["baseurl"] or default_server_address


self.instance = SingleInstance(
f"{self.client_name}-at-{server_host}-on-{server_port}"
Expand Down