-
Notifications
You must be signed in to change notification settings - Fork 594
[feat] Direct-call tools — Phase 1: call descriptor on the resolved spec #4889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,16 +56,35 @@ export interface TraceContext { | |
| * - `needsApproval`: gate the call on a human yes/no (mechanics owned by the run-event layer). | ||
| * - `render`: a generative-UI hint (see `RenderHint`). | ||
| * | ||
| * `callRef` is set for `callback` tools (the slug the bridge sends back to /tools/call); | ||
| * `runtime`/`code`/`env` for `code` tools. The Composio key and connection auth stay | ||
| * server-side. | ||
| * `callRef` is set for `callback` (gateway) tools (the slug the bridge sends back to | ||
| * /tools/call); `call` is set for direct-call callback tools (reference / platform), which the | ||
| * runner calls directly instead of routing through /tools/call. A callback spec carries `call` | ||
| * XOR `callRef`. `runtime`/`code`/`env` for `code` tools. The Composio key and connection auth | ||
| * stay server-side. | ||
| */ | ||
| export interface ResolvedToolSpec { | ||
| name: string; | ||
| description?: string; | ||
| inputSchema?: Record<string, unknown> | null; | ||
| /** Set for `callback` (gateway) tools only; absent for `code` / `client`. */ | ||
| /** Set for gateway `callback` tools (routes through /tools/call); absent for `code` / `client`, and absent when `call` is set. */ | ||
| callRef?: string; | ||
| /** | ||
| * Direct-call descriptor (direct-call tools, Phase 1). When set, the runner calls this Agenta | ||
| * endpoint DIRECTLY (reusing the run's `toolCallback.authorization`) instead of routing through | ||
| * `/tools/call`. `path` is an absolute path from the Agenta origin (the runner derives the | ||
| * origin from `toolCallback.endpoint`, so a tool can never reach a non-Agenta host); `body` are | ||
| * static server-fixed fields baked at resolve time; `context` maps a dotted body path to a | ||
| * `"$ctx.<key>"` token the runner fills from the run context at dispatch; `args_into` is the | ||
| * dotted path where the model's arguments are placed (absent = the body root). A spec carries | ||
| * `call` XOR `callRef`. Plumbing only here: nothing emits or dispatches it yet. | ||
| */ | ||
| call?: { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 The AI agent says: The same |
||
| method: "GET" | "POST"; | ||
| path: string; | ||
| body?: Record<string, unknown>; | ||
| context?: Record<string, string>; | ||
| args_into?: string; | ||
| }; | ||
| kind?: "callback" | "code" | "client"; | ||
| runtime?: "python" | "node"; | ||
| code?: string; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 The AI agent says: This is the
calldescriptor model on a resolved callback spec (callXORcall_ref). It is additive Phase 1 plumbing; nothing emits or dispatches it yet. Worth checking the shape againstinterfaces.md§1.