Skip to content

[fix] Correct the env-var name in the MCP-disabled error (AGENTA_AGENT_MCP_SERVERS_ENABLED) #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmabrouk merged 1 commit into from
Jun 28, 2026
Merged

[fix] Correct the env-var name in the MCP-disabled error (AGENTA_AGENT_MCP_SERVERS_ENABLED) #4899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/python/agenta/sdk/agents/mcp/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self, *, server_names: Sequence[str]) -> None:
listed = ", ".join(names) if names else "(unnamed)"
super().__init__(
"MCP servers are disabled on this deployment "
"(set AGENTA_AGENT_ENABLE_MCP to enable them), but the request declared "
"(set AGENTA_AGENT_MCP_SERVERS_ENABLED to enable them), but the request declared "

@mmabrouk mmabrouk Jun 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 The AI agent says: F-047 fix. This MCPDisabledError message named AGENTA_AGENT_ENABLE_MCP, which nothing reads. It now names the real gate AGENTA_AGENT_MCP_SERVERS_ENABLED (read at services/oss/src/agent/tools/resolver.py:24).

f"{len(names)} MCP server(s): {listed}. Remove them or enable MCP."
)
self.server_names = names
Expand Down
2 changes: 1 addition & 1 deletion services/agent/src/engines/sandbox_agent/mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export type McpServerEntry = McpServerStdio | McpServerHttp;
* SSRF guard for a user HTTP MCP `url`. The runner emits the run's Agenta-resolved named secrets
* as request headers to this author-supplied URL, so an attacker-controlled config could point it
* at an internal/metadata endpoint and exfiltrate a credential (a classic server-side request
* forgery). The capability is flag-gated (`AGENTA_AGENT_ENABLE_MCP`, off by default) and
* forgery). The capability is flag-gated (`AGENTA_AGENT_MCP_SERVERS_ENABLED`, off by default) and

@mmabrouk mmabrouk Jun 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 The AI agent says: Same F-047 fix in the runner SSRF-guard comment: the flag is AGENTA_AGENT_MCP_SERVERS_ENABLED, not AGENTA_AGENT_ENABLE_MCP. Comment text only, no behavior change.

* config-trust, so a scheme + host guard is enough rather than full DNS-resolution pinning:
*
* - require `https` (the secret rides in a header; `http` would send it in clear text). Opt out
Expand Down
Loading