Skip to content

revert(API): remove commit/patch router changes from #4936 - #4975

Closed
mmabrouk wants to merge 1 commit into
big-agentsfrom
revert/commit-revision-router-4936
Closed

revert(API): remove commit/patch router changes from #4936#4975
mmabrouk wants to merge 1 commit into
big-agentsfrom
revert/commit-revision-router-4936

revert(API): remove commit/patch router changes from #4936

e8325a6
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Application SDK Unit Test Results failed Jun 30, 2026 in 0s

1 fail, 1 167 pass in 18s

1 168 tests   1 167 ✅  18s ⏱️
    1 suites      0 💤
    1 files        1 ❌

Results for commit e8325a6.

Annotations

Check warning on line 0 in oss.tests.pytest.unit.agents.platform.test_op_catalog

See this annotation in the file changed.

@github-actions github-actions / Application SDK Unit Test Results

test_commit_revision_binds_self_and_strips_bound_field (oss.tests.pytest.unit.agents.platform.test_op_catalog) failed

sdks/python/oss/tests/results/junit.xml [took 0s]
Raw output
AssertionError: assert {'data', 'message'} == {'delta', 'message'}
  
  Extra items in the left set:
  'data'
  Extra items in the right set:
  'delta'
  
  Full diff:
    {
  -     'delta',
  ?       ^^
  +     'data',
  ?       ^
        'message',
    }
connection = <agenta.sdk.agents.platform.connection.PlatformConnection object at 0x7f482f1aa2d0>

    async def test_commit_revision_binds_self_and_strips_bound_field(connection):
        # "Update myself": the running variant id is bound from run context and stripped from the
        # model-visible schema, so the model supplies only the payload and can never retarget.
        resolution = await _resolver(connection).resolve(
            [PlatformToolConfig(op="commit_revision")]
        )
        spec = resolution.tool_specs[0]
        assert spec.call.path == "/api/workflows/revisions/commit"
        # The context binding rides as call.context — the runner fills it from runContext at dispatch.
        assert spec.call.context == {
            "workflow_revision.workflow_variant_id": "$ctx.workflow.variant.id"
        }
        # The bound field is gone from the model-visible schema (and its `required`); the payload fields
        # the model SHOULD supply remain.
        workflow_revision = spec.input_schema["properties"]["workflow_revision"]
        assert "workflow_variant_id" not in workflow_revision["properties"]
>       assert set(workflow_revision["properties"]) == {"message", "delta"}
E       AssertionError: assert {'data', 'message'} == {'delta', 'message'}
E         
E         Extra items in the left set:
E         'data'
E         Extra items in the right set:
E         'delta'
E         
E         Full diff:
E           {
E         -     'delta',
E         ?       ^^
E         +     'data',
E         ?       ^
E               'message',
E           }

oss/tests/pytest/unit/agents/platform/test_op_catalog.py:208: AssertionError