Skip to content

fix(sdk): stop span-attribute overflow from evicting trace references - #5206

Merged
mmabrouk merged 1 commit into
big-agentsfrom
fix/span-attr-limit-config-depth
Jul 10, 2026
Merged

fix(sdk): stop span-attribute overflow from evicting trace references#5206
mmabrouk merged 1 commit into
big-agentsfrom
fix/span-attr-limit-config-depth

fix(sdk): stop span-attribute overflow from evicting trace references

f8d41e3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Application SDK Unit Test Results failed Jul 10, 2026 in 0s

2 fail, 11 skipped, 1 763 pass in 27s

1 776 tests   1 763 ✅  27s ⏱️
    1 suites     11 💤
    1 files        2 ❌

Results for commit f8d41e3.

Annotations

Check warning on line 0 in oss.tests.pytest.unit.agents.test_dtos_agent_template

See this annotation in the file changed.

@github-actions github-actions / Application SDK Unit Test Results

test_run_selection_unknown_permission_falls_back_to_allow_reads (oss.tests.pytest.unit.agents.test_dtos_agent_template) failed

sdks/python/oss/tests/results/junit.xml [took 0s]
Raw output
agenta.sdk.agents.dtos.InvalidPermissionDefaultError: invalid runner.permissions.default 'surprise'; expected one of ['allow', 'allow_reads', 'ask', 'deny']
def test_run_selection_unknown_permission_falls_back_to_allow_reads():
>       config = AgentTemplate.from_params(
            {"runner": {"permissions": {"default": "surprise"}}}
        )

oss/tests/pytest/unit/agents/test_dtos_agent_template.py:264: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
agenta/sdk/agents/dtos.py:637: in from_params
    harness, sandbox, permission_default = _parse_run_selection(params, base)
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

params = {'runner': {'permissions': {'default': 'surprise'}}}
defaults = AgentTemplate(instructions=None, model=None, model_ref=None, tools=[], mcp_servers=[], skills=[], harness_permissions={}, harness_extras={}, sandbox_permission=None, harness='pi_core', sandbox='local', permission_default='allow_reads')

    def _parse_run_selection(
        params: Dict[str, Any],
        defaults: AgentTemplate,
    ) -> Tuple[str, str, PermissionMode]:
        """Pull the execution selectors (harness kind / sandbox kind / permission default).
    
        ``harness`` from ``harness.kind``, ``sandbox`` from ``sandbox.kind``, and the runner policy
        from ``runner.permissions.default``. The kinds and permission mode are lower-cased so
        playground-supplied values match the bare runtime selectors."""
        harness = str(_section(params, "harness").get("kind") or defaults.harness).lower()
        sandbox = str(_section(params, "sandbox").get("kind") or defaults.sandbox).lower()
        permissions = _section(params, "runner").get("permissions")
        raw_default = permissions.get("default") if isinstance(permissions, dict) else None
        if raw_default is None:
            permission_default = defaults.permission_default
        else:
            normalized = str(raw_default).lower()
            if normalized not in PERMISSION_MODES:
>               raise InvalidPermissionDefaultError(normalized)
E               agenta.sdk.agents.dtos.InvalidPermissionDefaultError: invalid runner.permissions.default 'surprise'; expected one of ['allow', 'allow_reads', 'ask', 'deny']

agenta/sdk/agents/dtos.py:1138: InvalidPermissionDefaultError

Check warning on line 0 in oss.tests.pytest.unit.agents.connections.test_capabilities

See this annotation in the file changed.

@github-actions github-actions / Application SDK Unit Test Results

test_unknown_harness_is_permissive (oss.tests.pytest.unit.agents.connections.test_capabilities) failed

sdks/python/oss/tests/results/junit.xml [took 0s]
Raw output
AssertionError: assert False is True
 +  where False = harness_allows_provider('some-future-harness', 'openai')
def test_unknown_harness_is_permissive():
>       assert harness_allows_provider("some-future-harness", "openai") is True
E       AssertionError: assert False is True
E        +  where False = harness_allows_provider('some-future-harness', 'openai')

oss/tests/pytest/unit/agents/connections/test_capabilities.py:58: AssertionError