fix(hosting): wire the session history flags into compose and the env examples#5488
fix(hosting): wire the session history flags into compose and the env examples#5488mmabrouk wants to merge 1 commit into
Conversation
… examples The runner service deliberately has no env_file, so AGENTA_SESSIONS_RECONSTRUCT and AGENTA_RECORDS_DURABLE were unreachable in every edition and could not be turned on outside a unit test. List them alongside the other runner variables and document all four flags in the env examples. Claude-Session: https://claude.ai/code/session_01KM69J7uHafgciiN5zfG7qR
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The problem
The runner service deliberately has no
env_file, so it only receives the environment variables compose lists by name.AGENTA_SESSIONS_RECONSTRUCTandAGENTA_RECORDS_DURABLEwere not listed in any of the four compose files.The practical effect is that the feature this stack sits on could not be turned on anywhere. Not in the dev stack, not in a self-hosted deployment. The only place the flags took effect was a unit test that sets them in-process. I found this while trying to stand up a deployment to QA #5486, which could not be done until this was fixed.
The fix
List both flags on the runner service in all four compose files (EE and OSS, dev and gh), and document all four session flags together in the env examples, including the constraint that the runner flag and the web flag have to be flipped together.
Testing
Deployed an EE dev stack from this branch and confirmed both variables arrive inside the runner container. All the QA in this stack depends on it.
Base of the fix stack for #5486.