[Common,Tutorial,PWGDQ,PWGEM,PWGJE,PWGUD] DPl Analysis: avoid including ASoA.h in dictionary generation#16823
Open
aalkin wants to merge 5 commits into
Open
[Common,Tutorial,PWGDQ,PWGEM,PWGJE,PWGUD] DPl Analysis: avoid including ASoA.h in dictionary generation#16823aalkin wants to merge 5 commits into
aalkin wants to merge 5 commits into
Conversation
github-actions
Bot
added
common
pwgje
pwgem
tutorial
pwgdq
pwgud
datamodel
photon
github-actions
Bot
changed the title
|
O2 linter results: ❌ 203 errors, |
aalkin
requested review from
alibuild,
amatyja,
dsekihat,
feisenhu,
fjonasALICE,
hscheid,
iarsene,
jokonig,
maoyx,
mcoquet642,
mfasDa,
mhemmer-cern,
mikesas,
nzardosh,
raymondEhlers,
rbailhac and
rolavick
as code owners
Collaborator
Collaborator
Member
|
@aalkin very nice! It looks like you forgot to add one file, though? Maybe we should split this by PWG so that the approval is faster? |
Member
Author
|
@ktf most of those are dependent on code from one another, unfortunately. |
Collaborator
|
Error while checking build/O2Physics/staging for 8579b48 at 2026-06-26 11:26: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 8579b48 at 2026-06-26 11:27: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 9d8f0ad at 2026-06-26 11:40: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 9d8f0ad at 2026-06-26 11:59: Full log here. |
iarsene
previously approved these changes
Jun 26, 2026
Collaborator
Member
|
Perfect, thanks. |
Collaborator
|
Error while checking build/O2Physics/o2 for be03d3a at 2026-06-29 09:28: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for faffeb9 at 2026-06-29 09:59: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for faffeb9 at 2026-06-29 10:55: Full log here. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various PWGs create ROOT dictionaries for some of their classes, which, unfortunately, through their inclusion chains pull ASoA.h and expose it to rootcling. ROOT's internal llvm is outdated and thus each time we need to update ASoA.h with new code, we have to employ workarounds in oder to keep O2Physics functional. This is highly inconvenient, and thus there will be an update in O2 that will explicitly forbid exposing ASoA.h to rootcling - the compilation will fail with an error. This PR removes all the instances of ASoA.h inclusion in dictionaries, that have been exposed by the upcoming O2 change.
This is a suggested change, the final fix may be different. Preferably, the dictionaries that are not required should be simply removed from CMakeLists.txt. From the codeowners, we request reviewing these changes, suggesting improvements, if needed, and validating that the updated code does not affect the analysis.
requires AliceO2Group/AliceO2#15557