feat: oauth - #1
Merged
Merged
Conversation
| run: pnpm typecheck | ||
|
|
||
| - name: test | ||
| run: pnpm vitest run |
Contributor
There was a problem hiding this comment.
@dbirman Testing takes a really long time (tens of seconds on a really strong PC)... are you sure you want to be running that every time you want to push? Typecheck on TS v6 is also really slow (maybe 10 seconds), and TS v7 (which fixes this) support won't come for Vue until v7.1. That's why I stripped out these two functions from lefthook and instead put them in GitHub Actions as required checks before PR merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.